Power up neccessary cores for decoding #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a schema description for the Venus video decoder/encoder IP in MSM8939. Signed-off-by: André Apitzsch <git@apitzsch.eu>
Add msm8939 configuration data and related compatible. Signed-off-by: André Apitzsch <git@apitzsch.eu>
Add DT entries for the msm8939 venus encoder/decoder. Signed-off-by: André Apitzsch <git@apitzsch.eu>
Enable the venus node so that the video encoder/decoder will start working. Signed-off-by: André Apitzsch <git@apitzsch.eu>
TODO: check if necessary Signed-off-by: André Apitzsch <git@apitzsch.eu>
Signed-off-by: Erikas Bitovtas <xerikasxx@gmail.com>
As seen in drivers/clk/qcom/gcc-msm8909.c, which has a Venus GDSC core with hardware power collapse control. In other words, much like msm8909, msm8939 has Venus GDSC cores with "qcom,support-hw-trigger" property set in the device tree.
TODO: check if neccessary, as it might break CAMSS on msm8939 Signed-off-by: Erikas Bitovtas <xerikasxx@gmail.com>
Signed-off-by: Erikas Bitovtas <xerikasxx@gmail.com>
Signed-off-by: Erikas Bitovtas <xerikasxx@gmail.com>
…CH_HALT" This reverts commit 5592286.
Signed-off-by: Erikas Bitovtas <xerikasxx@gmail.com>
Signed-off-by: Erikas Bitovtas <xerikasxx@gmail.com>
Signed-off-by: Erikas Bitovtas <xerikasxx@gmail.com>
Signed-off-by: Erikas Bitovtas <xerikasxx@gmail.com>
This is a hack because msm8916 does not support HEVC decoding, while msm8939 does. Signed-off-by: Erikas Bitovtas <xerikasxx@gmail.com>
This may break `gst-launch-1.0 videotestsrc ! videoconvert ! v4l2vp8enc ! queue ! v4l2vp8dec ! xvimagesink` for testing encoding. Signed-off-by: Erikas Bitovtas <xerikasxx@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes allow for powering on neccessary cores for decoding. This fixes the power collapse fail error and enables decoding.
ffplay command works, but is slow, gstreamer shows better performance. Playing video can be done with
gst-launch-1.0 playbin uri=file:/home/user/Downloads/video.mp4HEVC decoding works, but is currently a hack. A more flexible solution is neccessary.
Encoding fails with -EINVAL (-22). Tested with
ffmpeg -i input.mp4 -pix_fmt nv12 -c:v vp8_v4l2m2m -b:v 1M -c:a libvorbis output.mp4andgst-launch-1.0 videotestsrc ! videoconvert ! v4l2vp8enc ! queue ! v4l2vp8dec ! xvimagesinkCommit 9b64619 may cause firmware crashes when running
gst-launch-1.0 videotestsrc ! videoconvert ! v4l2vp8enc ! queue ! v4l2vp8dec ! xvimagesink, this is due to dmesg spam. The commit is used purely for debugging purposes and can be safely reverted without loss of functionality.