Skip to content

pickMatrix validation - 'center' function agrument is being validated instead of 'delta' #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 20, 2021
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions PyGLM/functions/stable_extensions/matrix_projection.h
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ pickMatrix_(PyObject*, PyObject* args) {
PyGLM_Vec_PTI_Assign0(2, float);
PyGLM_Vec_PTI_Assign1(2, float);
PyGLM_Vec_PTI_Assign2(4, float);
if (!(o.x > 0.0f && o.y > 0.0f)) {
if (!(o2.x > 0.0f && o2.y > 0.0f)) {
PyErr_SetString(PyExc_ValueError, "delta has to be greater than 0 for pickMatrix()");
return NULL;
}
Expand All @@ -36,7 +36,7 @@ pickMatrix_(PyObject*, PyObject* args) {
PyGLM_Vec_PTI_Assign0(2, double);
PyGLM_Vec_PTI_Assign1(2, double);
PyGLM_Vec_PTI_Assign2(4, double);
if (!(o.x > 0.0 && o.y > 0.0)) {
if (!(o2.x > 0.0 && o2.y > 0.0)) {
PyErr_SetString(PyExc_ValueError, "delta has to be greater than 0 for pickMatrix()");
return NULL;
}
Expand Down