Skip to content

Replaced uses of 'UNBRACKET' by typedefs to fix compiling on clang #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 30, 2021

Conversation

obiwac
Copy link
Contributor

@obiwac obiwac commented Apr 30, 2021

The 'UNBRACKET' macro (defined in PyGLM/compiler_setup.h) doesn't seem to work everywhere with clang 10.0.1 (on FreeBSD 12.2-RELEASE), so replaced by types.

Also added explicit cast to silence warning.

@Zuzu-Typ
Copy link
Owner

Hey there :)

Thank you very much for your contribution!

@Zuzu-Typ Zuzu-Typ self-assigned this Apr 30, 2021
@Zuzu-Typ Zuzu-Typ added the bug label Apr 30, 2021
@Zuzu-Typ Zuzu-Typ merged commit 5005d00 into Zuzu-Typ:master Apr 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants