Rename new extension method to EquivalentTo

Author: KenHundley

src/Amazon.Extensions.Configuration.SystemsManager/Internal/DictionaryExtensions.cs

@@ -19,9 +19,9 @@ namespace Amazon.Extensions.Configuration.SystemsManager.Internal
 {
     public static class DictionaryExtensions
     {
-        public static bool DictionaryEqual<TKey, TValue>(this IDictionary<TKey, TValue> first, IDictionary<TKey, TValue> second) => DictionaryEqual(first, second, null);
+        public static bool EquivalentTo<TKey, TValue>(this IDictionary<TKey, TValue> first, IDictionary<TKey, TValue> second) => EquivalentTo(first, second, null);
 
-        public static bool DictionaryEqual<TKey, TValue>(this IDictionary<TKey, TValue> first, IDictionary<TKey, TValue> second, IEqualityComparer<TValue> valueComparer)
+        public static bool EquivalentTo<TKey, TValue>(this IDictionary<TKey, TValue> first, IDictionary<TKey, TValue> second, IEqualityComparer<TValue> valueComparer)
         {
             if (first == second) return true;
             if (first == null || second == null) return false;

src/Amazon.Extensions.Configuration.SystemsManager/SystemsManagerConfigurationProvider.cs

@@ -113,7 +113,7 @@ private async Task LoadAsync(bool reload)
 
                 var newData = ProcessParameters(parameters, path);
 
-                if (!Data.DictionaryEqual(newData))
+                if (!Data.EquivalentTo(newData))
                 {
                     Data = newData;
 

test/Amazon.Extensions.Configuration.SystemsManager.Tests/DictionaryExtensionsTests.cs

@@ -7,13 +7,13 @@ namespace Amazon.Extensions.Configuration.SystemsManager.Tests
     public class DictionaryExtensionsTests
     {
         [Theory]
-        [MemberData(nameof(DictionaryEqualsData))]
-        public void TestDictionaryEquals(IDictionary<string, string> first, IDictionary<string, string> second, bool equals)
+        [MemberData(nameof(EquivalentToData))]
+        public void TestEquivalentTo(IDictionary<string, string> first, IDictionary<string, string> second, bool equals)
         {
-            Assert.Equal(equals, first.DictionaryEqual(second));
+            Assert.Equal(equals, first.EquivalentTo(second));
         }
 
-        public static TheoryData<IDictionary<string, string>, IDictionary<string, string>, bool> DictionaryEqualsData => new TheoryData<IDictionary<string, string>, IDictionary<string, string>, bool>
+        public static TheoryData<IDictionary<string, string>, IDictionary<string, string>, bool> EquivalentToData => new TheoryData<IDictionary<string, string>, IDictionary<string, string>, bool>
         {
             {new Dictionary<string, string>(), new Dictionary<string, string>(), true},
             {new Dictionary<string, string>(), null, false},