Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings - Customization of the website #13

Open
3 of 15 tasks
NightScript370 opened this issue May 22, 2023 · 1 comment
Open
3 of 15 tasks

Settings - Customization of the website #13

NightScript370 opened this issue May 22, 2023 · 1 comment

Comments

@NightScript370
Copy link
Member

NightScript370 commented May 22, 2023

Jews will always want options; that's why we have two Jews and three opinions. Our site will definitely be used by people everywhere, and while we'll have the best defaults, we need to make sure the options would highlight exactly what the end-user would like. Thereby, I'd like to separate all available options into different categories:

Zmanim

  • Location: This will be the first option, where the user would be faced with the input field that they were first greeted with. This bar has the ability to put the location name to get the longitude and latitude results from the API, with two buttons on the right side to set it based on the user location or to manually insert the longitude & latitude. Default will be user location, unless the end user refuses to provide the permission, in which case this will be the only option that will affect whether or not you can close the modal.
  • Calender Psak option: This will only show if the Location above is NOT found in Eretz Yisrael. The user will have the option to choose between "Amudeh Hora'ah" or "Ohr Hachaim", with a description that says the difference is whether degrees are used. We need to decide which one will be default, considering that currently, our two haskamah givers prefer one method over the other while the right way in Eretz Yisrael is arguing on those Haskamah givers. If we get an Haskamah from the Rebeim in Eretz Yisrael, I would be comfortable with putting Ohr Hachaim as default.
  • Customizable Times: A subsection where you can specify exactly how many minutes you want for various different options:
    • Candle Lighting: Number Field where you can specify however many numbers you want to put for Candle Lighting. Presets will be based on Shitat Hayereim: 15 (22.5m mil), 18 (24m mil), 20 (24m mil rounded, default), 22.5 (full mil) & 40 (minhag Yerushalayim). We should place this in a list as the description, with reasons why each number would be used.
    • Shabbat Ending times: Default is 30 minutes for those using degrees, 40 for those using fixed. Let people enter a custom time, with presets including Ashkenazi sides.
    • Fast End: Rabbi David Yosef (20m seasonal), Ben Ish Hai (27m seasonal), Hakham Ben Tzion Aba Shaul (30 minutes fixed)
    • Plag Hamincha & Hatzot Laylah: Rabbi Ovadia (Symmetric), Ben Ish Hai (Alot til Psak Tzet), Ben Tzion (Netz till Tzet)

Visuals

  • Language: What's the point of having a website if the end user cannot even read it? There will be three different options: Hebrew, English Transliterated & English. The selector will be a radio slider with Hebrew on the left, English Transliterated in the middle and English on the right. The description of this setting should give an example of each way of writing. Keep in mind that we also need to determine which method of transliteration we'll go with; I would prefer the more authentic Sepharadi way (Ch -> H for Hets, use th's when Ashkenazim would use a s for a Taw without a Dagesh, Waw instead of Vav), but obviously this is...controversial.
  • Layout: TV Layout vs Vertical Mode - Differences already explained in another issue Layout implementation for daily view #3
  • Theme Override: I feel comfortable "hiding" this by putting this below Zmanim considering that most people will be using non-EOL browsers which will already support the dark theme media query. Thereby, this setting will default itself to "Auto" with an option to put it in Force Dark and Force Light. Force Light will change the media query of dark.css to something that will always be false (made-up media query, which will be ironic if a browser in 200 years from now decides to name for their media query). Force Dark will change the media query to only check if the user is looking at a screen, which will only be false if the user is printing it (which, let's be real; if the user wants to print the page, we shouldn't be using dark theme anyway). It will be a radio slider with the force dark in the left, auto in the middle and force light on the right side
  • Time Format: ברוך שלא עשני אמרכני - We Canadians use the 24h system format by default, which is what the rest of the world uses. However, since the primary developer is American, we will be forced to accommodate the 12h system. To settle the score between us, we will let it be an option, with 12h being the default.
  • Seconds Display: Currently, we use a system where we either do not show the seconds at all or force display it in the menu. Despite being unreliable, I don't think those that want to see the seconds for one small activity should have to modify it via going to a modal, toggling the option and then exiting the modal, only to redo that for disabling the seconds view. Instead, we should use tooltips to show the user the seconds when they aren't explicitly printed on the screen. Thereby, the options will be "Tooltip" (default) and "Force print". Of course, description will warn the severity of the seconds.
  • Plag Hamincha: We currently have two different Plag Haminchas; one for the more machmir and one that's more traditional. Obviously, we should be encouraging people to follow the Shita decided by our Posek, so there wouldn't be an option to leave just the Mekel Shita. However, since having both Shitas at all times is screen-clutter, we'll add an option to hide the more Mekel shita and rename the Machmir Shita to just "Plag Hamincha"

Functionality

  • Notifications: Configure which times get notifications, with options to specify how earlier the notification would come.
  • ChaiTable Netz Force Disable: By default, NetzTable will be enabled. However, because ISPs could be annoying the end user because of how many pages it would try to access, we need to have an option that would force usage of the regular zmanim.
@Elyahu41
Copy link
Collaborator

Elyahu41 commented May 22, 2023

Very nice! I agree with everything listed above. I will try to get a haskamah from Rabbi Shlomo Benizri, however, as he only speaks and reads Hebrew (with a little English). I believe that we should first translate the site to Hebrew and then show that version to the Rabbi so he could look at it and confirm it.

As a side note, we need to decide where to put the link for the FULLY Hebrew version of the website.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants