-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(regtest): Add regtest halving interval and port test #8888
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking good, the only blocker is an update to the height_for_first_halving()
method so it returns FIRST_HALVING_TESTNET
on custom testnets, or ideally the correct value. I'll try writing a halving_for_height()
function so we can use the correct value there.
Update: FUNDING_STREAM_ADDRESS_CHANGE_INTERVAL
and the funding_stream_address_period()
are also using the constant post blossom halving interval.
…test" (#8894) * adds `height_for_halving_index()` and `num_halvings()` fns * avoid unnecessary panic * avoid using constant pre/post blossom halving intervals in num_halvings()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking great, the only potential blocker is an update to TestnetParameterSubsidyImpl
to account for the halving interval and Blossom activation height when validating configured funding streams.
…reams, updates funding stream setter methods to set a flag indicating that parameters affecting the funding stream address period should be locked, updates the setter methods for parameters that affect the funding stream address period to panic if those parameters should be locked. (#8921)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Motivation
We want to be able to configure the halving interval when we are in custom testnet or use the fixed default in regtest.
Close #8880
Solution
FIRST_HALVING_REGTEST
at height 144 to match zcashd regtest mode.halving_interval
for custom testnets.Nu6
andNU6
in rpc outputs.Tests
./qa/pull-tester/rpc-tests.py nuparams
PR Author's Checklist
PR Reviewer's Checklist