Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(workflows): mass rename worflows to fix readme badges #8116

Merged
merged 1 commit into from
Dec 18, 2023
Merged

Conversation

oxarbitrage
Copy link
Contributor

Motivation

Our badges images are broken because we changed the workflow names but never upgraded the codebase for this changes.

Close #7931

PR Author Checklist

Check before marking the PR as ready for review:

  • Will the PR name make sense to users?
  • Does the PR have a priority label?
  • Have you added or updated tests?
  • Is the documentation up to date?

Solution

Mass rename was done using fastmod with the following commands:

  • [CI Docker]
fastmod --hidden --fixed-strings 'continous-integration-docker.yml' 'ci-integration-tests-gcp.yml' /home/oxarbitrage/zebra/issue7931/zebra
  • [CI OSes]
 fastmod --hidden --fixed-strings 'continous-integration-os.yml' 'ci-unit-tests-os.yml' /home/oxarbitrage/zebra/issue7931/zebra
  • [Continuous Delivery]
fastmod --hidden --fixed-strings 'continous-delivery.yml' 'cd-deploy-nodes-gcp.yml' /home/oxarbitrage/zebra/issue7931/zebra
  • [Build docs]
fastmod --hidden --fixed-strings 'docs.yml' 'docs-deploy-firebase.yml' /home/oxarbitrage/zebra/issue7931/zebra

The line change in .cargo/config.toml was done manually.

Testing

You cancheck badges are using by visiting the branch of this PR: https://github.com/ZcashFoundation/zebra/tree/issue7931

Review

Anyone can review.

Reviewer Checklist

Check before approving the PR:

  • Does the PR scope match the ticket?
  • Are there enough tests to make sure it works? Do the tests cover the PR motivation?
  • Are all the PR blockers dealt with?
    PR blockers can be dealt with in new tickets or PRs.

And check the PR Author checklist is complete.

Follow Up Work

@oxarbitrage oxarbitrage added A-docs Area: Documentation A-devops Area: Pipelines, CI/CD and Dockerfiles P-Low ❄️ labels Dec 18, 2023
@oxarbitrage oxarbitrage requested review from a team as code owners December 18, 2023 13:39
@oxarbitrage oxarbitrage requested review from upbqdn and removed request for a team December 18, 2023 13:39
@oxarbitrage oxarbitrage self-assigned this Dec 18, 2023
@github-actions github-actions bot added the C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG label Dec 18, 2023
Copy link
Member

@gustavovalverde gustavovalverde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this!

mergify bot added a commit that referenced this pull request Dec 18, 2023
@mergify mergify bot merged commit 2d217e2 into main Dec 18, 2023
156 checks passed
@mergify mergify bot deleted the issue7931 branch December 18, 2023 21:07
@oxarbitrage oxarbitrage mentioned this pull request Jan 17, 2024
41 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-devops Area: Pipelines, CI/CD and Dockerfiles A-docs Area: Documentation C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Workflow icons are broken in the README
2 participants