-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(scan): Add raw database format snapshots to the scanner #8075
Conversation
8a13d78
to
96cc3bf
Compare
codespell failed, restarting: https://github.com/ZcashFoundation/zebra/actions/runs/7141093973/job/19447724265?pr=8075 |
Thanks for fixing up the imports, that was a bit of a mistake from me! |
8c77b6e
to
441299d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Motivation
These are part of the standard database tests in #8069.
PR Author Checklist
Check before marking the PR as ready for review:
If a checkbox isn't relevant to the PR, mark it as done.
Complex Code or Requirements
Not really, it's just the same as the state.
Solution
Related changes:
Testing
These are extra tests.
I have manually checked the data formats in the snapshots and they appear correct.
Review
Because of the code movement, the state db test APIs, and the storage API changes, this PR blocks other tests. So it would be good to get it merged soon. It doesn't need to be in the release.
Reviewer Checklist
Check before approving the PR:
PR blockers can be dealt with in new tickets or PRs.
And check the PR Author checklist is complete.
Follow Up Work
The rest of the tests in #8069