-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change(scan): Create a function that scans one block by height, and stores the results in the database #8045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teor2345
added
C-cleanup
Category: This is a cleanup
P-Medium ⚡
C-trivial
Category: A trivial change that is not worth mentioning in the CHANGELOG
A-blockchain-scanner
Area: Blockchain scanner of shielded transactions
labels
Dec 4, 2023
9 tasks
upbqdn
previously approved these changes
Dec 5, 2023
Co-authored-by: Marek <mail@marek.onl>
upbqdn
previously approved these changes
Dec 5, 2023
Just an import merge conflict, should be fixed now. |
teor2345
commented
Dec 5, 2023
upbqdn
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-blockchain-scanner
Area: Blockchain scanner of shielded transactions
C-cleanup
Category: This is a cleanup
C-trivial
Category: A trivial change that is not worth mentioning in the CHANGELOG
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This is a quick follow up to a bunch of recent scanner changes.
@upbqdn or @oxarbitrage this might conflict with what you're working on, but I'm happy to re-do it, because your PRs are actually changing things.
PR Author Checklist
Check before marking the PR as ready for review:
If a checkbox isn't relevant to the PR, mark it as done.
Solution
Most of these arguments are cheap to clone, but if we have a lot of keys the key sets could be very large, so I used
Arc
.Testing
This is just a cleanup of the previous PR.
Review
This is a routine cleanup.
Reviewer Checklist
Check before approving the PR:
PR blockers can be dealt with in new tickets or PRs.
And check the PR Author checklist is complete.