Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(scanner): Add a very basic RAM database to store keys and scan results #7942

Merged
merged 5 commits into from
Nov 15, 2023

Conversation

oxarbitrage
Copy link
Contributor

Motivation

We want to have a database with viewing keys and scanning results. The scanner task can get the keys to scan from this database and insert results of found transactions.

This is the most basic version i was able to do with a simple test.

Should close #7904, unblock #7941 and partially unblock #7928

PR Author Checklist

Check before marking the PR as ready for review:

  • Will the PR name make sense to users?
  • Does the PR have a priority label?
  • Have you added or updated tests?
  • Is the documentation up to date?

Solution

Add a basic storage for the blockchain scanner project.

Testing

A new test that uses the new database was added.

Review

I am open to suggestions if we keep the PR simple, i prefer to open new tickets for more complex tasks.

Reviewer Checklist

Check before approving the PR:

  • Does the PR scope match the ticket?
  • Are there enough tests to make sure it works? Do the tests cover the PR motivation?
  • Are all the PR blockers dealt with?
    PR blockers can be dealt with in new tickets or PRs.

And check the PR Author checklist is complete.

Follow Up Work

@oxarbitrage oxarbitrage added P-Medium ⚡ A-blockchain-scanner Area: Blockchain scanner of shielded transactions labels Nov 14, 2023
@oxarbitrage oxarbitrage requested a review from a team as a code owner November 14, 2023 19:18
@oxarbitrage oxarbitrage requested review from arya2 and removed request for a team November 14, 2023 19:18
@github-actions github-actions bot added the C-feature Category: New features label Nov 14, 2023
zebra-scan/src/storage.rs Outdated Show resolved Hide resolved
zebra-scan/src/storage.rs Outdated Show resolved Hide resolved
teor2345
teor2345 previously approved these changes Nov 14, 2023
Copy link
Collaborator

@teor2345 teor2345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great!

All of my suggestions are optional, but some of them are so detailed that they belong in other tickets. So I'll go and open those tickets now. (And resolve those comments.)

zebra-scan/src/storage.rs Outdated Show resolved Hide resolved
zebra-scan/src/storage.rs Outdated Show resolved Hide resolved
zebra-scan/src/storage.rs Outdated Show resolved Hide resolved
zebra-scan/src/storage.rs Outdated Show resolved Hide resolved
zebra-scan/src/storage.rs Outdated Show resolved Hide resolved
zebra-scan/src/storage.rs Outdated Show resolved Hide resolved
Copy link
Collaborator

@teor2345 teor2345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

mergify bot added a commit that referenced this pull request Nov 15, 2023
@mergify mergify bot merged commit 732ee01 into main Nov 15, 2023
104 checks passed
@mergify mergify bot deleted the issue7904 branch November 15, 2023 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-blockchain-scanner Area: Blockchain scanner of shielded transactions C-feature Category: New features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(zebra-scan): Create a key storage database in RAM
2 participants