-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(scanner): Add a very basic RAM database to store keys and scan results #7942
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great!
All of my suggestions are optional, but some of them are so detailed that they belong in other tickets. So I'll go and open those tickets now. (And resolve those comments.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Motivation
We want to have a database with viewing keys and scanning results. The scanner task can get the keys to scan from this database and insert results of found transactions.
This is the most basic version i was able to do with a simple test.
Should close #7904, unblock #7941 and partially unblock #7928
PR Author Checklist
Check before marking the PR as ready for review:
Solution
Add a basic storage for the blockchain scanner project.
Testing
A new test that uses the new database was added.
Review
I am open to suggestions if we keep the PR simple, i prefer to open new tickets for more complex tasks.
Reviewer Checklist
Check before approving the PR:
PR blockers can be dealt with in new tickets or PRs.
And check the PR Author checklist is complete.
Follow Up Work