poc(scanner): get started with the blockchain scanner proof of concept #7758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
oxarbitrage
commented
Oct 19, 2023
github-actions
bot
added
the
C-trivial
teor2345
reviewed
Oct 24, 2023
teor2345
reviewed
Oct 24, 2023
teor2345
reviewed
Oct 24, 2023
teor2345
reviewed
Oct 24, 2023
teor2345
reviewed
Oct 24, 2023
teor2345
reviewed
Oct 24, 2023
|
Should be merged after the release so i added the do not merge label. |
This was referenced Nov 3, 2023
oxarbitrage
added
the
A-blockchain-scanner
3 tasks
teor2345
reviewed
Nov 8, 2023
teor2345
previously approved these changes
Nov 8, 2023
There was a problem hiding this comment.
Looks great, thanks!
Using the correct docs URL is a blocker. There are some other things that could be cleaned up to avoid confusion later.
I've resolved most of my optional suggestions, please only look at them if you have time and motivation to polish this code. (I'm guessing some parts are going to end up as production code.)
|
I don't need to review this again, so @arya2 feel free to approve it after any minor changes. |
teor2345
reviewed
Nov 8, 2023
teor2345
reviewed
Nov 8, 2023
Co-authored-by: teor <teor@riseup.net>
Co-authored-by: teor <teor@riseup.net>
Co-authored-by: teor <teor@riseup.net>
Co-authored-by: teor <teor@riseup.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Create a new crate
zebra-scanand put proof of concept tests into it.Part of #7727
Review
Follow Up Task
Build crates individually / Build zebra-scan crate