fix(app): Stop panicking at startup when parsing the app version - release blocker #6888
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Zebra panics in some git/machine environments when running app_version() at startup.
When we changed the version to 1.0.0, this code would always have panicked, because it expected a pre-release version.
I also fixed a similar potential panic in the get_info RPC version code.
Close #6879
Specifications
https://semver.org/#semantic-versioning-specification-semver
For the RPC:
https://github.com/bitcoin/bips/blob/master/bip-0014.mediawiki#proposal
Complex Code or Requirements
The previous code had a bunch of undocumented assumptions. This code is longer but all the assumptions are spelled out, and the
expect()
s are justified.Solution
git
version parsing, removing most of the panicsReview
This is an urgent release blocker.
Reviewer Checklist
Follow Up Work
We could add tests for this parsing, but there isn't much point because the remaining panics should be impossible.