build(deps): Upgrade to ed25519-zebra 4.0.0

[dconnolly]

Motivation

Aligns with other dependencies that also rely on curve25519-dalek 4.0.0+

Solution

• Upgrade zebra-chain
• Upgrade tower-batch dev dependencies
• Remove curve25519-dalek denial in deny.toml
• Update Cargo.lock via cargo update

Confirmed via cargo tree --duplicates that we have no curve25519-dalek duplicate versions.

Review

Reviewer Checklist

• Will the PR name make sense to users?
  • Does it need extra CHANGELOG info? (new features, breaking changes, large changes)
• Are the PR labels correct?
• Does the code do what the ticket and PR says?
  • Does it change concurrent code, unsafe code, or consensus rules?
• How do you know it works? Does it have tests?

[teor2345]

This is failing due to a duplicate hashbrown dependency.

The command-line for checking for duplicate dependencies is:

cargo deny check bans

We can add this to #6859 if you'd like instead.

[dconnolly]

This is failing due to a duplicate hashbrown dependency.

The command-line for checking for duplicate dependencies is:

cargo deny check bans

We can add this to #6859 if you'd like instead.

Ah I think I updated the deny.toml just as you replied about that 😁

[teor2345]

Ah I think I updated the deny.toml just as you replied about that

It might be nice to have a "bless" script, because it would always get the crates and versions right. The tricky part would be when it creates over-broad exceptions. I guess we could just add exceptions for each duplicate crate directly.

[dconnolly]

oop github is being weird for me so i'll put this at the top level,

@teor2345 This is interesting, I ran the command from CI which uses --all-features and it pinned on 0.13.2 and only because of ed25519-zebra and metrics-exporter-prometheus; I do see the other crates and other hashbrown version with just cargo deny check bans; is the one in CI incorrect?

[codecov]

Codecov Report

Merging #6881 (8c289cd) into main (9959a6c) will decrease coverage by 0.15%.
The diff coverage is n/a.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #6881      +/-   ##
==========================================
- Coverage   77.72%   77.58%   -0.15%     
==========================================
  Files         310      310              
  Lines       41416    41416              
==========================================
- Hits        32192    32134      -58     
- Misses       9224     9282      +58     

[teor2345]

I ran the command from CI which uses --all-features and it pinned on 0.13.2 and only because of ed25519-zebra and metrics-exporter-prometheus; I do see the other crates and other hashbrown version with just cargo deny check bans; is the one in CI incorrect?

CI runs both commands in a matrix, and both of them must pass. (With and without --all-features.)

[dconnolly]

I ran the command from CI which uses --all-features and it pinned on 0.13.2 and only because of ed25519-zebra and metrics-exporter-prometheus; I do see the other crates and other hashbrown version with just cargo deny check bans; is the one in CI incorrect?

CI runs both commands in a matrix, and both of them must pass. (With and without --all-features.)

Ah I missed that, thanks!