fix(build): add elasticsearch feature to block serialize

[oxarbitrage]

Motivation

Close #6695

Solution

Add elasticsearch feature to block serialization.

Review

Reviewer Checklist

• Will the PR name make sense to users?
  • Does it need extra CHANGELOG info? (new features, breaking changes, large changes)
• Are the PR labels correct?
• Does the code do what the ticket and PR says?
  • Does it change concurrent code, unsafe code, or consensus rules?
• How do you know it works? Does it have tests?

Follow Up Work

[codecov]

Codecov Report

Merging #6709 (a809644) into main (6549357) will decrease coverage by 0.03%.
The diff coverage is 37.50%.

❗ Current head a809644 differs from pull request most recent head 29ff651. Consider uploading reports for the commit 29ff651 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #6709      +/-   ##
==========================================
- Coverage   77.66%   77.64%   -0.03%     
==========================================
  Files         310      310              
  Lines       41475    41477       +2     
==========================================
- Hits        32211    32204       -7     
- Misses       9264     9273       +9     

[teor2345]

Did you manually test the same command that failed in the ticket?

[oxarbitrage]

This is working:

 cargo install zebrad  --locked --git https://github.com/ZcashFoundation/zebra --branch es-serialize-buld-error zebrad

[teor2345]

Are you missing --features="elasticsearch"?

[oxarbitrage]

Yea, sorry, i just noticed that. Trying again.

[teor2345]

Are you missing --features="elasticsearch"?

If this was a production feature, we'd add a CI test that specifically tried this compile. But since it's experimental it's ok to break it in some circumstances.

[oxarbitrage]

I changed it back to draft as it seems the changes did not worked with the full correct command i wanted to fix:

$ cargo install zebrad --features="elasticsearch" --locked --git https://github.com/ZcashFoundation/zebra --branch es-serialize-buld-error zebrad
...
error[E0277]: the trait bound `zebra_chain::block::Block: Serialize` is not satisfied
   --> zebra-state/src/service/finalized_state.rs:388:23
    |
388 |                 .push(serde_json::json!(block).to_string());
    |                       ^^^^^^^^^^^^^^^^^^^^^^^^
    |                       |
    |                       the trait `Serialize` is not implemented for `zebra_chain::block::Block`
    |                       required by a bound introduced by this call
    |
    = help: the following other types implement trait `Serialize`:
              &'a T
              &'a mut T
              ()
              (T0, T1)
              (T0, T1, T2)
              (T0, T1, T2, T3)
              (T0, T1, T2, T3, T4)
              (T0, T1, T2, T3, T4, T5)
            and 276 others
...

[teor2345]

We'll need to chain the feature activations between different crates.

[teor2345]

Looks good, thanks!

I'm assuming you did the manual test again?

[teor2345]

Thanks!

I want to approve, but someone needs to manually test that this works first.

[oxarbitrage]

I tested this manually and it is working.