Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ux): Disable issue URLs for a known shutdown panic in abscissa #6486

Merged
merged 3 commits into from
Apr 14, 2023

Conversation

teor2345
Copy link
Contributor

Motivation

When the running zebrad binary is updated, Abscissa panics on shutdown due to an application path check.

It should ignore the path error instead, hopefully this is fixed by the latest Abscissa version in #5502.

In the meantime, we don't want users to report this known issue as a new bug.

Solution

  • Disable issue URLs for this specific panic message

Review

This is a low priority usability fix.

Reviewer Checklist

  • Will the PR name make sense to users?
    • Does it need extra CHANGELOG info? (new features, breaking changes, large changes)
  • Are the PR labels correct?
  • Does the code do what the ticket and PR says?
    • Does it change concurrent code, unsafe code, or consensus rules?
  • How do you know it works? Does it have tests?

@teor2345 teor2345 added C-bug Category: This is a bug P-Low ❄️ I-panic Zebra panics with an internal error message I-usability Zebra is hard to understand or use A-diagnostics Area: Diagnosing issues or monitoring performance labels Apr 12, 2023
@teor2345 teor2345 requested a review from a team as a code owner April 12, 2023 01:22
@teor2345 teor2345 self-assigned this Apr 12, 2023
@teor2345 teor2345 requested review from dconnolly and removed request for a team April 12, 2023 01:22
@github-actions github-actions bot added the C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG label Apr 12, 2023
@codecov
Copy link

codecov bot commented Apr 12, 2023

Codecov Report

Merging #6486 (0458124) into main (3d11a09) will decrease coverage by 0.11%.
The diff coverage is 0.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6486      +/-   ##
==========================================
- Coverage   77.80%   77.70%   -0.11%     
==========================================
  Files         304      305       +1     
  Lines       39678    40100     +422     
==========================================
+ Hits        30870    31158     +288     
- Misses       8808     8942     +134     

Co-authored-by: Deirdre Connolly <durumcrustulum@gmail.com>
@teor2345
Copy link
Contributor Author

Failed due to #6498:
https://github.com/ZcashFoundation/zebra/actions/runs/4689185183/jobs/8310618954?pr=6486#step:10:2650

A different job failed due to a timing issue in components::mempool::storage::tests::prop::eviction_list_time_mixed:

Message: Test failed: assertion failed: e.contains_key(&txid.mined_id()) at zebrad/src/components/mempool/storage/tests/prop.rs:1124; minimal failing input: mut rejection_template = Legacy(transaction::Hash("966cb0ddd6f9dd0a3e556c9d1a11bd83af71e97707602b62b5580aae1885cbf0"))

https://github.com/ZcashFoundation/zebra/actions/runs/4689185170/jobs/8310620107?pr=6486#step:14:3624

mergify bot added a commit that referenced this pull request Apr 14, 2023
mergify bot added a commit that referenced this pull request Apr 14, 2023
@mergify mergify bot merged commit cf6d0cc into main Apr 14, 2023
@mergify mergify bot deleted the ignore-shutdown-panic branch April 14, 2023 04:36
@arya2 arya2 mentioned this pull request Apr 18, 2023
36 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-diagnostics Area: Diagnosing issues or monitoring performance C-bug Category: This is a bug C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG I-panic Zebra panics with an internal error message I-usability Zebra is hard to understand or use
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants