-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(release): create Docker hub binary with mining enabled on release #6228
Conversation
02f6ccb
to
193ed22
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm concerned that we are creating a duplicate Dockerfile, it will be much harder to maintain than the single test/production Dockerfile we have at the moment.
Can we make the mining RPCs depend on a Docker argument instead?
This PR will need a rebase on the latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wasn't able to see this PR previously, but I do agree we need to make this happen on our existing Dockerfile.
@arya2 let me know if you'd like some help with this changes.
… Testnet by default, and an RPC port
…letd tests conditional
61c627c
to
ced6cbe
Compare
Duplicate files have been resolved
Co-authored-by: teor <teor@riseup.net>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, but I think we need to test it by making a fake .test
release. workflow_dispatch
won't work on this workflow, so we'll need to do the test after merging to main
.
Here's the kinds of things I want to check:
- Is the test or production image the first image that users see?
- If users are pulling down the
latest
image, do they always get the production image? - Is the test image clearly marked as experimental?
If it could be confusing, our other option is to:
- Use a different project name like
zfnd/zebra-experimental
- Remove any images we've pushed to the
zfnd/zebra
DockerHub
@Mergifyio refresh |
✅ Pull request refreshed |
@mpguerra @arya2 when do you think we should do this testing? Is it ok to wait until the next release and just see what happens? |
Motivation
We want to make it easy for miners to test Zebra's getblocktemplate RPC methods.
Closes #6200.
Solution
getblocktemplate-rpcs
feature enabledReview
Anyone can review.
Reviewer Checklist