-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add instructions for mining with s-nomp to Zebra book #6220
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
I don't mind either way. |
nest under mining Co-authored-by: Arya <aryasolhi@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, i made a suggestion to be more clear that the s-nomp
guide is not production but feel free to ignore it.
Motivation
Detailed mining instructions point back to this zebra github repo instead of the Zebra book even though they are within the book directory.
Solution
Add the file to the contents on
SUMMARY.md
and link to its location in the book.Review
Do we actually want to show this in the book or was it fine the way it was?
Reviewer Checklist
Follow Up Work