-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change(ci): add acceptance test for getblocktemplate RPC in CI, and fix RPC bugs #5761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teor2345
added
C-bug
Category: This is a bug
A-devops
Area: Pipelines, CI/CD and Dockerfiles
P-Medium ⚡
I-integration-fail
Continuous integration fails, including build and test failures
C-testing
Category: These are tests
A-rpc
Area: Remote Procedure Call interfaces
labels
Dec 1, 2022
github-actions
bot
added
C-enhancement
Category: This is an improvement
C-feature
Category: New features
C-trivial
Category: A trivial change that is not worth mentioning in the CHANGELOG
labels
Dec 1, 2022
teor2345
force-pushed
the
gbt-sync-until-test-fix
branch
from
December 1, 2022 03:05
c45e5f1
to
cfe5e04
Compare
teor2345
force-pushed
the
gbt-sync-until-test-fix
branch
from
December 1, 2022 03:27
096eb4e
to
4eb310b
Compare
I have run this RPC manually thousands of times, and it seems to work (and it's very fast) |
This was referenced Dec 1, 2022
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #5761 +/- ##
==========================================
+ Coverage 78.69% 78.73% +0.04%
==========================================
Files 306 306
Lines 38687 38687
==========================================
+ Hits 30445 30461 +16
+ Misses 8242 8226 -16 |
teor2345
commented
Dec 1, 2022
arya2
approved these changes
Dec 1, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-devops
Area: Pipelines, CI/CD and Dockerfiles
A-rpc
Area: Remote Procedure Call interfaces
C-bug
Category: This is a bug
C-enhancement
Category: This is an improvement
C-feature
Category: New features
C-testing
Category: These are tests
C-trivial
Category: A trivial change that is not worth mentioning in the CHANGELOG
I-integration-fail
Continuous integration fails, including build and test failures
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We want to test the getblocktemplate RPC with a synced Zebra instance.
We tried this in PR #5653, but the RPC had some bugs, so we had to revert it.
Closes #5652.
Solution
Review
This is a high priority, because it stops us adding more bugs to the getblocktemplate RPC.
Reviewer Checklist
Follow Up Work