change(consensus): Update mainnet and testnet checkpoints on 2022-12-01 #5754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teor2345
added
A-consensus
github-actions
bot
added
the
C-trivial
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #5754 +/- ##
=======================================
Coverage 78.74% 78.74%
=======================================
Files 306 306
Lines 38687 38687
=======================================
+ Hits 30463 30465 +2
+ Misses 8224 8222 -2 |
arya2
approved these changes
Dec 1, 2022
|
Merge queue failed with
https://github.com/ZcashFoundation/zebra/actions/runs/3588904675/jobs/6041323885#step:8:297 |
|
@Mergifyio refresh |
✅ Pull request refreshed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We need to update the checkpoints to speed up full syncs on the main branch.
This is based on the "settled network upgrade" consensus rule.
Designs
Follow the instructions for updating the checkpoints from
zcashd.Review
Updating the checkpoints is urgent because it might fix full sync timeouts on the main branch.
Reviewer Checklist
Follow Up Work
We might need to add further jobs or increase the Rust test timeout if this isn't enough.