fix(sync): Make the syncer ignore some new block verification errors

[teor2345]

Motivation

The syncer skips some duplicate block errors, but we added new duplicate block errors in #4937.

This might fix the full sync errors on the main branch.

Solution

• Ignore "block has already been sent to be committed to the state" errors
• Make a finalized state error into "block has already been committed to the state"

Review

I talked through this with @arya2 already.

Reviewer Checklist

• Will the PR name make sense to users?
  • Does it need extra CHANGELOG info? (new features, breaking changes, large changes)
• Are the PR labels correct?
• Does the code do what the ticket and PR says?
• How do you know it works? Does it have tests?

Follow Up Work

We should fix these permanently using typed errors, so we don't introduce this sort of bug again:

• Improve VerifyBlockError::Commit typing, so we don't accidentally break syncer error handling #2908

[arya2]

This looks good!

[codecov]

Codecov Report

Merging #5537 (6574cd5) into main (34313b8) will increase coverage by 0.02%.
The diff coverage is 16.66%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5537      +/-   ##
==========================================
+ Coverage   78.76%   78.79%   +0.02%     
==========================================
  Files         305      305              
  Lines       38114    38118       +4     
==========================================
+ Hits        30022    30035      +13     
+ Misses       8092     8083       -9     

[arya2]

@Mergifyio refresh

[mergify]

refresh

✅ Pull request refreshed

[arya2]

A couple failures in the merge queue, the clippy lint:

error: the Err-variant returned from this function is very large
--> zebrad/src/components/sync.rs:1027:10
|
1027 | ) -> Result<(), BlockDownloadVerifyError> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the Err-variant is at least 144 bytes

https://github.com/ZcashFoundation/zebra/actions/runs/3387578258/jobs/5628508335#step:8:501

and compiling in ubuntu-latest:

2022-11-03T18:02:59.1665948Z Couldn't compile the test.test src/components/mempool/crawler.rs - components::mempool::crawler (line 16) ... FAILED
2022-11-03T18:02:59.1670828Z
2022-11-03T18:02:59.1671033Z failures:
2022-11-03T18:02:59.1671272Z
2022-11-03T18:02:59.1675686Z failures:
2022-11-03T18:02:59.1686048Z src/components/mempool/crawler.rs - components::mempool::crawler (line 16)

These are failing on the main branch too

[teor2345]

These are failing on the main branch too

Looks like Rust 1.65:
https://blog.rust-lang.org/2022/11/03/Rust-1.65.0.html#generic-associated-types-gats

I can open PRs to fix them now.

If it's not caused by this specific PR, can you please open a ticket, or ask the person on main branch failures to open one?
That's @oxarbitrage this week.

[arya2]

Looks like Rust 1.65: https://blog.rust-lang.org/2022/11/03/Rust-1.65.0.html#generic-associated-types-gats

Sounds about right. I created #5547.

[teor2345]

Looks like Rust 1.65: https://blog.rust-lang.org/2022/11/03/Rust-1.65.0.html#generic-associated-types-gats

Sounds about right. I created #5547.

I try to catch these things by running nightly rust, but sometimes they slip through, or I ignore them, or they are merged right before the release.

[teor2345]

@Mergifyio update

[mergify]

update

✅ Branch has been successfully updated

[teor2345]

@Mergifyio refresh

[mergify]

refresh

✅ Pull request refreshed