Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): a path must exist before creating a file in it #5177

Merged
merged 3 commits into from
Sep 15, 2022

Conversation

gustavovalverde
Copy link
Member

Motivation

Builds in the main branch are failing

Solution

Other directories in the Dockerfile were automatically created with the WORKDIR and COPY commands. In this case it has to be explicitly created

Review

Anyone can review this, and it's urgently needed

Other directories in the Dockerfile were automatically created with the `WORKDIR` and  `COPY` commands. In this case it has to be explicitly created
@gustavovalverde gustavovalverde added C-bug Category: This is a bug A-devops Area: Pipelines, CI/CD and Dockerfiles P-Critical 🚑 I-integration-fail Continuous integration fails, including build and test failures I-build-fail Zebra fails to build labels Sep 15, 2022
@gustavovalverde gustavovalverde self-assigned this Sep 15, 2022
@gustavovalverde gustavovalverde marked this pull request as ready for review September 15, 2022 15:37
@gustavovalverde gustavovalverde requested a review from a team as a code owner September 15, 2022 15:37
@gustavovalverde gustavovalverde requested review from teor2345 and removed request for a team September 15, 2022 15:37
Copy link
Member

@upbqdn upbqdn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I left a minor suggestion.

docker/Dockerfile Show resolved Hide resolved
mergify bot added a commit that referenced this pull request Sep 15, 2022
@mergify mergify bot merged commit 726f732 into main Sep 15, 2022
@mergify mergify bot deleted the fix-zebra-conf-path branch September 15, 2022 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-devops Area: Pipelines, CI/CD and Dockerfiles C-bug Category: This is a bug I-build-fail Zebra fails to build I-integration-fail Continuous integration fails, including build and test failures
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants