-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(rpc): add support for verbosity=1 in getblock #4511
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conradoplg
changed the title
add support for getblock with verbosity=1
feat(rpc): add support for verbosity=1 in getblock
May 26, 2022
This is new:
Retrying in case it's something temporary |
Codecov Report
@@ Coverage Diff @@
## main #4511 +/- ##
==========================================
- Coverage 78.92% 78.86% -0.07%
==========================================
Files 304 304
Lines 37285 37301 +16
==========================================
- Hits 29426 29416 -10
- Misses 7859 7885 +26 |
{
+ "hash": "0000000000e4db798f4fe57a76342c93ff5bf57fda8f6bbd2c4f37ff1eac4ebe",
+ "confirmations": 1,
+ "size": 3029,
+ "height": 1681412,
+ "version": 4,
+ "merkleroot": "ac1f954e4cea5960d19c9b0e4de2746d2b493930eab6cb2104d943810c6f36ee",
+ "blockcommitments": "41b6f89095084d2cb13ef66fb2ababcf371ebf71709d143a1175fdd08b64c675",
+ "authdataroot": "0000000000000000000000000000000000000000000000000000000000000000",
+ "finalsaplingroot": "525210ac04203202b9607a38be692a48a8c479f1af65b596d20c22e8abc90888",
+ "chainhistoryroot": "41b6f89095084d2cb13ef66fb2ababcf371ebf71709d143a1175fdd08b64c675",
"tx": [
"d6a5068722aa09eba2fb45d9a470442884ca0cdf4b9735cf683984689d8f688f",
"ed807a7b2823fdd253063bc061901f7c528b9c61692c412d80a5866200556ab7",
@@ -6,5 +16,39 @@
"736ec41da874ee1229145bac4e76e15b40754eeacc53dfe3e45c6de8ece7d8dc",
"5c18f65f5a6286356996eb21d53f67547500a15b7e17f6b1833d826ab7c825ad",
"c0dc391f73f2aa1a03ef329b9d3f210fd4dce383fff23e14b5ca731076e69119"
- ]
+ ],
+ "time": 1653589006,
+ "nonce": "07b40540000000000000000000020000000000000000000000000000ff910028",
+ "solution": "00f1b0949e81c06f5b658233af6e20e89f41f6877c27b25a63d90fb144f0b009527266d37ad63d1bb09107ca5d05b3cea6b90adee9ec9cdcade34bb49e679c27a5933b7ace3305c34ff6e6716a8dc9e62872f1980133a773aacb120a6729f3f95e22c42af052fef4f019b3c90ddbccb76b5d10221df591bb9e84ec96f2990679f9d8f6c1d196f8bbd1379eca075b4624deaec720d0134a29e3300f3bf8b2ae7f7a0025d7a03ca65a0c093a5f9610988a9283f3fe033a665a3262392b5b170f1b866456b9bb9a67a3eb6ef777ff1b80fe984c0c9442630e437431599f36ee85452c1a9392f6aef31db0797ad589d9da81ed6930eadbaa9e56235aef570ec5393290a83b19e759a7b3bb697fe6aaeb75ef1825d22c2712a74681b34b42db86d9d0c90e6d56dea739c77cc0d45d597bc8339a840559d9eb2552bd41aa5b5ec40c981b011be04f17c17d4c0d6b41331fe94803719f41ae18bab58f9aa5a914499322cdd9b7487a306b5a9c5966436fed7cf53262ef04662ff5fcdee42ff485a6ac15d581d4255422a2ba5ac677f4163c6f462d9ae1e517a3e79bac14c976b0558a4d37160a6c0c24492c98a73eabb48b717a97b6d8c22cbbf84bc729bc72d052d1596f8db2a80c15661cdaff9d9be77e211044668b940c7700e263351d21e0a91b505cf0f95064269f89a30573f642d90fb9cbc29a795f761f0d081bc2dabed0a9a7272a00f280e06ed09423382d123f433d0b325fc155d136d3fea07504df0822bee48311132a7cce694a23e84362a408d9607db7e0b931a9281ba315dfd448ef66a0a46deaefe8052ce02f68a80f0d4e5d23507ee6fcecea64275b05869a631544561fa2a1c0c5dc735d2e5be2cd6b572763b601fe470311062a474ad335af4b4a529d872b56c2cdc1d9842a577cab595ea356cd60f4467e48b65a31c4d9f8bbbc015be914ab5dd45af8d5f4b621c294dd8fa8f9caa54443874614d789e4cd6647abd4eee6ea10e9b9354c03aee01f8654c7e9384272ceb6cf2d161a0dbe2e6c3ba5ea5c9dbe223ff8b596e10374dc3e64e4bc9e80055cbcf906124450f13d52ec2cfda6594cd17508180f87ad6d144a276596c571d0dfe872896b7fedde7f220aad13e20aae83c12e047f1fd1b21e89e9b8b99d3b7974b39d0f0b3b58ca659b84ef93ff00b2d9b57e02dda022a11f6eebd4c104e56b609e5251091f9e96056c710666f3bd05f9f940c1a19a9c94efd708018c0ce5f66760860a7bf63a32b96eb0f83db780b99f160ce6936c0c761b57e64ca2b628ed17d7bdc23f2dbe04b97864ae9c611be46d0453d9a7d9f961a7ad3bc5078fbf9eb78350387264f0f62f12155354223d6c33194fcc4574ed8b2fe736d83c12fd5492ba92385b2b4374258dd92477f9d8fcd5b3d16977a62a0673e6e1016fbcb05198b8378d2477f5acdcbe1a18559ca19c1e508763b92537658c7bf78037cc07e650f59cc9ec12e2dbc68b2eb333dac2b2d575d7b410e3d18ba6c1167449775ad2bf2aeab32456b95438f1fe3c99dbf90cadad5f900cbc769f5c61e79e3de7792cf87f456843b12a6aa46a7e256623c71252f8d53664d9bb44dd230e169935a221b9bbf3d2e3d5d4944e2e42b22d332b4a42d3ff8ff3bf1235f4d9fec09cf5519afa71780952fb6844a648056d508354839fed55b367f229bf0fb25f95f31ca6a3e64de2cfb6421f527d9c1f4c1b155205213ca2fb15e07c67ded243e81651dd1443de293d64be0daafe519fa1829825ecb1e2ca12feeead1aa4ca18bf9befcf1975046843290015bf693848401d586f57b54f5943b8e756d81dcdcce9bf1dbac009278f1647114b3ead9d46c30a05be9d79c8f010ed7e3d9f0a920dcf7b82867dc409ef5dd49d77389e79ef",
+ "bits": "1c01397d",
+ "difficulty": 109604329.370765,
+ "chainwork": "0000000000000000000000000000000000000000000000000940cb160412eb17",
+ "anchor": "8a13d46e012838e2f778247e2411b08418294fe3d910bedacb79f9bb9b3c5566",
+ "valuePools": [
+ {
+ "id": "sprout",
+ "monitored": true,
+ "chainValue": 28202.85123855,
+ "chainValueZat": 2820285123855,
+ "valueDelta": 0.00000000,
+ "valueDeltaZat": 0
+ },
+ {
+ "id": "sapling",
+ "monitored": true,
+ "chainValue": 793275.18024018,
+ "chainValueZat": 79327518024018,
+ "valueDelta": 0.00000000,
+ "valueDeltaZat": 0
+ },
+ {
+ "id": "orchard",
+ "monitored": true,
+ "chainValue": 0.00000000,
+ "chainValueZat": 0,
+ "valueDelta": 0.00000000,
+ "valueDeltaZat": 0
+ }
+ ],
+ "previousblockhash": "000000000106b9fe70379bcea0c4699f6dce309c3348cf6f7f5b02dbe163b5b3"
}
|
teor2345
approved these changes
May 27, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
teor2345
added
C-enhancement
Category: This is an improvement
P-Medium ⚡
A-rpc
Area: Remote Procedure Call interfaces
lightwalletd
any work associated with lightwalletd
labels
May 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-rpc
Area: Remote Procedure Call interfaces
C-enhancement
Category: This is an improvement
lightwalletd
any work associated with lightwalletd
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
See #4480
Specifications
Designs
Solution
Closes #4480
Review
This is required (i.e. will break CI if this is not merged) only if Aditya's lightwalletd is synced with upstream (which we have no idea when/if will happen). Anyone can review.
Reviewer Checklist
Follow Up Work