Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change(ci): list cached state files before or after tests #4409

Merged
merged 1 commit into from
May 17, 2022
Merged

change(ci): list cached state files before or after tests #4409

merged 1 commit into from
May 17, 2022

Conversation

teor2345
Copy link
Contributor

Motivation

Some of the cached states aren't being built correctly, which causes all lightwalletd cached state jobs to fail.

This PR lists the cached state files when the cached state is created or required.

Solution

  • list all lightwalletd cached state files when it is used
  • list top-level zebrad cached state directories when it is used (there are too many files)

Review

This is an urgent PR, because we need it to diagnose CI failures.

Reviewer Checklist

  • Code passes CI

Follow Up Work

If these diagnostics don't help, we could open a ticket to list the created state heights for zebrad and lightwalletd.
(They already log them when they start up, but we also want to list them after we create the state.)

@teor2345 teor2345 added C-bug Category: This is a bug A-devops Area: Pipelines, CI/CD and Dockerfiles P-Critical 🚑 I-integration-fail Continuous integration fails, including build and test failures C-testing Category: These are tests A-state Area: State / database changes lightwalletd any work associated with lightwalletd labels May 17, 2022
@teor2345 teor2345 self-assigned this May 17, 2022
@teor2345 teor2345 requested a review from a team as a code owner May 17, 2022 00:25
@teor2345 teor2345 requested review from gustavovalverde and removed request for a team May 17, 2022 00:25
mergify bot added a commit that referenced this pull request May 17, 2022
@mergify
Merge of #4409
35e06ef
@mergify mergify bot mentioned this pull request May 17, 2022
Closed
48 tasks
@mergify mergify bot merged commit 12d0e24 into main May 17, 2022
@mergify mergify bot deleted the list-cache-files branch May 17, 2022 02:32
@teor2345 teor2345 mentioned this pull request May 17, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dconnolly dconnolly dconnolly approved these changes

@gustavovalverde gustavovalverde Awaiting requested review from gustavovalverde gustavovalverde is a code owner automatically assigned from ZcashFoundation/devops-reviewers

Assignees

@teor2345 teor2345

Labels
A-devops Area: Pipelines, CI/CD and Dockerfiles A-state Area: State / database changes C-bug Category: This is a bug C-testing Category: These are tests I-integration-fail Continuous integration fails, including build and test failures lightwalletd any work associated with lightwalletd
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@teor2345 @dconnolly