change: NU5 mainnet dependency upgrades #4405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conradoplg
requested review from
upbqdn and
teor2345
and removed request for
a team
conradoplg
commented
May 16, 2022
|
@Mergifyio update |
✅ Branch has been successfully updated |
|
I'm updating this PR to clear most of the test failures, the remaining ones are: |
dconnolly
reviewed
May 18, 2022
|
Whoops sorry I missed the lockfile |
|
@Mergifyio update |
✅ Branch has been successfully updated |
3 tasks
teor2345
reviewed
May 18, 2022
There was a problem hiding this comment.
In general we try to specify dependencies down to the patch level (1.0.0), rather than the minor version level (1.0).
That way, dependency upgrades are always shown in Cargo.tomls, and we don't have to go searching through Cargo.lock to work out what they are.
If we need to urgently merge this PR, this is not a blocker.
teor2345
added
A-dependencies
48 tasks
51 tasks
dconnolly
added a commit
that referenced
this pull request
May 19, 2022
mergify bot
pushed a commit
that referenced
this pull request
May 19, 2022
#4430) * bump versions * add the changelog for beta 10 * Update CHANGELOG.md Co-authored-by: Marek <mail@marek.onl> * Distinguish CI and Rust dependency updates * Include all the dep bumps in PR #4405 * join 2 dependencies * Include incrementalmerkletree dep bump in changelog Co-authored-by: Deirdre Connolly <durumcrustulum@gmail.com> Co-authored-by: Marek <mail@marek.onl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We need to update dependencies for the NU5 mainnet release, matching the
zcashd 5.0.0dependencies.Specifications
Designs
Solution
Closes #3414
Closes #4335
Review
Anyone can review.
This is currently possibly blocked on us tagging/releasing new versions of
zcash_scriptandredjubjub, but that will only require changing the references in the TOML files so this PR can already be reviewed.Reviewer Checklist
Follow Up Work