Open
Description
openedon May 17, 2023
Motivation
We currently have a separate test file for end of support tests, which makes cargo
link zebrad
into two different test binaries. This increases build time and test size on disk.
Specifications
Each file in the tests directory is a separate crate, so we need to bring our library into each test crate’s scope. For that reason we add use adder at the top of the code, which we didn’t need in the unit tests.
https://doc.rust-lang.org/book/ch11-03-test-organization.html#integration-tests
Suggested Solution
- Rewrite the
tracing_test
tests to check a result from theend_of_support::check()
method, rather than checking the logs directly - Move those tests into
acceptance.rs
, like in https://github.com/ZcashFoundation/zebra/tree/cleanup-eos-test - Remove the
tracing_test
dependency
Testing
The updated tests should pass.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Metadata
Assignees
Labels
Type
Projects
Status
New