Skip to content

Minigame command #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Jul 13, 2020
Merged

Minigame command #23

merged 16 commits into from
Jul 13, 2020

Conversation

Leguu
Copy link

@Leguu Leguu commented Jun 30, 2020

No description provided.

@Leguu Leguu added the wip Something is a work in progress label Jun 30, 2020
duncte123
duncte123 reviewed Jun 30, 2020
View reviewed changes
Copy link
Member

@duncte123 duncte123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will not accept a direct copy-paste from the js version

@Leguu Leguu linked an issue Jul 1, 2020 that may be closed by this pull request
Minigame command #13
Open
duncte123
duncte123 reviewed Jul 1, 2020
View reviewed changes
duncte123
duncte123 requested changes Jul 12, 2020
View reviewed changes
@Leguu Leguu marked this pull request as ready for review July 12, 2020 08:39
@Leguu Leguu added review me Pull requests that need to be reviewed and removed wip Something is a work in progress labels Jul 12, 2020
duncte123
duncte123 requested changes Jul 12, 2020
View reviewed changes
@Leguu
Merge branch 'develop' into feaure/minigame
7d007b0 
# Conflicts:
#	src/main/kotlin/io/github/yuutoproject/yuutobot/commands/base/CommandCategory.kt
zsotroav
zsotroav requested changes Jul 12, 2020
View reviewed changes
zsotroav
zsotroav requested changes Jul 12, 2020
View reviewed changes
@Leguu Leguu force-pushed the feaure/minigame branch from a635bee to 4650d33 Compare July 13, 2020 08:20
duncte123
duncte123 previously approved these changes Jul 13, 2020
View reviewed changes
Copy link
Member

@duncte123 duncte123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will be re-written in the next release

zsotroav
zsotroav requested changes Jul 13, 2020
View reviewed changes
Copy link

@zsotroav zsotroav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only have one really really small problem

@Leguu @zsotroav
fix small grammar error
cbff6c1 
Co-authored-by: zsotroav <49715074+zsotroav@users.noreply.github.com>
@Leguu Leguu dismissed stale reviews from duncte123 via cbff6c1 July 13, 2020 08:49
@duncte123 duncte123 merged commit 247a08e into develop Jul 13, 2020
@duncte123 duncte123 deleted the feaure/minigame branch July 13, 2020 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@duncte123 duncte123 duncte123 approved these changes

@zsotroav zsotroav zsotroav approved these changes

Assignees
No one assigned
Labels
review me Pull requests that need to be reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Minigame command
3 participants
@Leguu @duncte123 @zsotroav