This repository was archived by the owner on Apr 21, 2024. It is now read-only.
Form skills #29
Merged
Form skills #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for dev-cv-ycc ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Contributor
Author
|
Hi @YuriDevAT ,thanks for your response sorry I got confused that why I kept closing the PR😅 I thought it was the right thing to do |
YuriDevAT
suggested changes
Oct 12, 2022
Member
YuriDevAT
left a comment
YuriDevAT
left a comment
There was a problem hiding this comment.
It looks good now 🙂 . One little suggestion, the Skills component should appear before the blank CV component, to be together with the other forms. I will merge after your change.
Contributor
Author
|
ok I have done so as required |
Member
|
Great work @Fomonyuytar-Joseph. 🥳 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For an example of how to fill this template out, see this Pull Request in the Wiki.
Description
Add
Skillsto components folder in thesrcadd form to
Skills.jsAcceptance Criteria
Type of Changes
Updates
After