Read report lengths from descriptor on Windows #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmeum
force-pushed
the
fhenneke_rpt_size_win
branch
2 times, most recently
from
6b9d1df
to
8d67b36
Compare
|
I have now tested this successfully. Testing showed that previously debug warnings would be emitted for non-FIDO devices, which has now been fixed. |
martelletto
reviewed
May 14, 2020
Extracts input and output report lengths from the report descriptor using HidP_GetCaps. Since the previous implementation rejected all devices with report lengths other than 64 bytes (+ report ID), we can reject devices with invalid report lengths without affecting backward compatibility.
fmeum
force-pushed
the
fhenneke_rpt_size_win
branch
from
8d67b36
to
9615aba
Compare
|
Thanks! Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracts input and output report lengths from the report descriptor
using HidP_GetCaps.
Since the previous implementation rejected all devices with report
lengths other than 64 bytes (+ report ID), we can reject devices with
invalid report lengths without affecting backward compatibility.
This has been tested lightly tested with both a 64 byte and a 62 byte FIDO device, further testing will be done after #181 has been resolved.