Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lookup credentials based only on user_handle instead of user_name #317

Open
yunhao-cash opened this issue Sep 12, 2023 · 10 comments
Open

Lookup credentials based only on user_handle instead of user_name #317

yunhao-cash opened this issue Sep 12, 2023 · 10 comments

Comments

@yunhao-cash
Copy link

yunhao-cash commented Sep 12, 2023

Hello team,

I've observed that sometime we use user_name to look up stored public key credentials, examples are when we resolve the allowCredentials list in authentication ceremony and excludeCredentials list in registration ceremony.

I wonder if we can just use user_handle to resolve for credential instead? as user_handle is more "immutable" than user_name, which could be changed from time to time.

Is that to accomodate sometime user_handle is missing but only user_name is presenting?

@emlun
Copy link
Member

emlun commented Sep 13, 2023

Hi! This sounds like a duplicate of issue #274, which is about supporting username-less accounts. There is some experimental support for that available, see the most recent few comments in the #274 thread. Does that answer your questions?

@yunhao-cash
Copy link
Author

Hi! This sounds like a duplicate of issue #274, which is about supporting username-less accounts. There is some experimental support for that available, see the most recent few comments in the #274 thread. Does that answer your questions?

Hi, thanks for the response! I take a look at the v2 interface, it seems exactly fit our need - prefer using user_handle as the key to fetch data in the repository. I wonder what's the plan for promoting the experimental branch to mainline, is there any plan for that?

@emlun
Copy link
Member

emlun commented Sep 21, 2023

We want to do it eventually, but there's no concrete time plan at the moment. Perhaps in one or two months from now, but I can't promise that either. Sorry I can't give you a better answer.

@emlun
Copy link
Member

emlun commented Sep 21, 2023

But please let us know if there's a particular time frame that would help you, and we can take that into consideration when prioritizing work. We could probably also make the v2 interfaces available in a shorter time frame as an experimental release, like 2.6.0-alpha1, if you need it for prototyping.

@yunhao-cash
Copy link
Author

yunhao-cash commented Sep 21, 2023

But please let us know if there's a particular time frame that would help you, and we can take that into consideration when prioritizing work. We could probably also make the v2 interfaces available in a shorter time frame as an experimental release, like 2.6.0-alpha1, if you need it for prototyping.

Thanks for quick reply, I think releasing it to an alpha could help a lot and we will start integrating v2 repository.

Our feature is not launched yet, we do want to launch it sometime in Q4 (October/November 2023), integrating with v2 repository will allow us to avoid some user_name -> user_handle lookup so if time permits we do want to include it in the first release.

@emlun
Copy link
Member

emlun commented Sep 28, 2023

Thanks for letting us know! I can't promise an experimental release yet, but we'll let you know if we set a planned release date.

@emlun
Copy link
Member

emlun commented Oct 24, 2023

Hi again! We're aiming to make the experimental release with the new V2 interfaces soon, hopefully this week or next week. Would that be helpful for you?

@yunhao-cash
Copy link
Author

Hi again! We're aiming to make the experimental release with the new V2 interfaces soon, hopefully this week or next week. Would that be helpful for you?

That would be awesome and will help our timeline 🙏

@emlun
Copy link
Member

emlun commented Nov 8, 2023

Sorry, the release has slipped a bit, but we hope to finish it this week.

@emlun
Copy link
Member

emlun commented Nov 9, 2023

This is now released in experimental release 2.6.0-alpha4. Thanks for your patience!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants