Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the phrase "dumb down" and improve feedback for the word "lame" in the Inclusive language assessment #21578

Open
wants to merge 2 commits into
base: feature/inclusive-language-fixes
Choose a base branch
from

Conversation

hannaw93
Copy link
Contributor

Context

Summary

This PR can be summarized in the following changelog entry:

  • Adds the phrase "dumb down" to the inclusive language assessment.
  • Improves the feedback for "lame" in the inclusive language assessment.
  • [shopify-seo] Adds the phrase "dumb down" to the inclusive language assessment.
  • [shopify-seo] Improves the feedback for "lame" in the inclusive language assessment.

Relevant technical choices:

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

  • Active Yoast SEO Free
  • Activate the Inclusive language assessment in the settings
  • Add a text of at least 300 words
  • Add the phrase "dumb" to the text
  • Confirm that the inclusive language assessment shows red with the following feedback:
    "Avoid using dumb as it is potentially harmful. Consider using an alternative, such as uninformed, ignorant, foolish, inconsiderate, irrational, reckless. Learn more.".
  • Add the phrase "dumb down" to the text
  • Confirm that a second feedback appears under the inclusive language assessment with a red bullet ""Avoid using dumb down as it is potentially harmful. Consider using an alternative, such as oversimplify. Learn more."
  • Change the form of the phrase "dumb down" to "dumbed down"
  • Confirm that the previous score disappeared and this similar feedback string appeared instead: "Avoid using dumbed down as it is potentially harmful. Consider using an alternative, such as oversimplify. Learn more."
  • Remove the previous text and add a new text of at least 300 words
  • Add the phrase "dumbing down"
  • Confirm that the Inclusive language feedback shows red with the following feedback: "Avoid using dumbing down as it is potentially harmful. Consider using an alternative, such as oversimplify. Learn more."
  • Add the phrase "lame"
  • Confirm that a second feedback appears under the inclusive language assessment with an orange bullet and the following feedback: "Be careful when using lame as it is potentially harmful. Unless you are referring to an object, considering using an alternative. For example, boring, lousy, unimpressive, sad, corny. If referring to someone's disability, use an alternative such as person with a disability, person who has difficulty with walking. Learn more.".

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

UI changes

  • This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

  • I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

Fixes #

@hannaw93 hannaw93 added the changelog: enhancement Needs to be included in the 'Enhancements' category in the changelog label Aug 30, 2024
@hannaw93 hannaw93 changed the base branch from trunk to feature/inclusive-language-fixes August 30, 2024 13:33
@hannaw93 hannaw93 marked this pull request as ready for review August 30, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: enhancement Needs to be included in the 'Enhancements' category in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant