Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New General page: alert center notification breaking out of space #21714

Open
igorschoester opened this issue Oct 16, 2024 · 0 comments
Open

Comments

@igorschoester
Copy link
Member

igorschoester commented Oct 16, 2024

What is the goal of this issue?

  • Use the test helper to reset your FTC progress, options and whatever is needed to get the notification with the Start SEO data optimization button, as show in the screenshot below
  • Enable the feature flag
  • Visit the General page
  • Have the screen width between 1024 and 1124 pixels
  • Notice the Start SEO data optimization notification is pushing its button out of bounds
    image
  • Hide the notification in question
  • Have a screen width between 1024 and 1248 pixels
  • Notice it is even worse now
    image

What needs to be done to achieve the goal?

WP styling includes a white-space: nowrap; style on the .button class, which that Start SEO data optimization has.
However, there is still not enough room then between 1024 and ~1090 pixels.
image
I haven't figured out why that is. But could be better to just change when the cards go below each other instead?

Does the issue still need UX or research?

If available: what are the tips for fixing the problem or possible solutions?

What is the expected result/behavior?

Should documentation be added or updated for this change? and if so, where?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant