Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter 'wpseo_should_index_links' does not work #18131

Open
2 tasks done
dbliang opened this issue Feb 27, 2022 · 2 comments
Open
2 tasks done

Filter 'wpseo_should_index_links' does not work #18131

dbliang opened this issue Feb 27, 2022 · 2 comments

Comments

@dbliang
Copy link

dbliang commented Feb 27, 2022

  • I've read and understood the contribution guidelines.
  • I've searched for any related issues and avoided creating a duplicate issue.

Please give us a description of what happened.

The filter 'wpseo_should_index_links' no longer works.

It looks like this wasn't implemented in the rewrite, as it's no longer functioning and I don't see any usage of the wpseo_should_index_links filter in ./src/builders/indexable-link-builder.php (assuming this is the file it would have to be in).

Related:

#12751
#9474

Please describe what you expected to happen and why.

Instead of wp_yoast_seo_links repopulating, it should stay at 0.

How can we reproduce this behavior?

  1. Disable "Text link counter" under SEO -> General -> Features
  2. Implement filter as per Add wpseo_should_index_links filter #12751
  3. Reset YOAST's tables using Tools -> YOAST Test -> Reset Indexables tables and migrations

Used versions

  • WordPress version: 5.9.1
  • Yoast SEO version: 18.2
@Djennez
Copy link
Member

Djennez commented Mar 1, 2022

I've asked this internally, but the way it works now is intended. It currently only disables the link count columns on post overview pages, but it does not disable the link count functionality itself, because that is needed for certain functionality. It needs documentation changes.

@monbauza
Copy link

Being able to completely disable the calculation of internal links would be helpful in cases where it causes performance issues. See for example #16713

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants