Make wpseo-dismiss-public-notice a site wide notification

[karlijnbok]

Roadmap issue: Yoast/roadmap#102
Product owner: @JessieHenkes

Is your feature request related to a problem? Please describe.

As mentioned in Yoast/roadmap#102

Note I've kept the "site not public notification out of this on purpose. This is so critical it should be a site wide thing.

Right now, it is only shown in the SEO Dashboard (SEO > General) in the Problems section.

Describe the solution you'd like

The wpseo-dismiss-public-notice should become a site-wide, dismissible notification.

wpseo-dismiss-public-notice can be found in admin/class-admin-init.php

Current notification copy:

Huge SEO Issue: You're blocking access to robots.

[afercia]

Note to myself:

the WPSEO_Option_Wpseo->clean_option() method was progressively "emptied" in #4713, #4710, and #4709. It now needs to be partially restored for the ignore_blog_public_warning option.

[afercia]

Note 2:

Not sure there's a way to display the admin notice in Gutenberg. There was a back-compat for admin-notices implemented in WordPress/gutenberg#11604 and then removed in WordPress/gutenberg#12444.

There's now the @wordpress/notices package which registers a core/notices data store and can be accessed for example this way:

wp.data.dispatch( 'core/notices' ).createSuccessNotice( 'ciao' )

or

wp.data.dispatch( 'core/notices' ).createErrorNotice( 'I am an error.' )

etc. Of course this works only in Gutenberg and would need its own implementation.

[afercia]

Current work in progress status:

I restored the old copy text. Should we review a bit the copy, especially for the don't bug me part?

Huge SEO Issue: You're blocking access to robots. You must go to your Reading Settings and uncheck the box for Search Engine Visibility. I know, don't bug me.

/Cc @jdevalk @JessieHenkes

[jdevalk]

Let's change it to:

Huge SEO Issue: You're blocking access to robots. If you want search engines to show this site in their results, you must go to your Reading Settings and uncheck the box for Search Engine Visibility.

Replace "I know, don't bug me" with:

I don't want this site to show in the search results.

[jdevalk]

Sorry I think I've not thought this through enough when I said this, after multiple discussions the last few days. We should clarify what we mean with "sitewide", or more specifically: maybe not use that term. I'm open to suggestions.

I want these notifications to show on:

• Dashboard
• Plugins page
• Update core page
• Yoast SEO settings pages

Nowhere else :)

My apologies to @afercia and the rest of the team for the unneeded work done here.

[roryashfordbentley]

Hey!

Would it be possible tto make this notice dismissable?

We typically have a live site and a staging site for our clients. When this message appears on the staging server our clients are reaching out to inform us of a 'Huge SEO problem' when in actuality we want to discourage search engines on the staging server.

Edit: I realise now that you can dismiss it by clicking on "I dont want this site to show in search results, sorry!!".

[jdevalk]

@roryashfordbentley that's a very valid request but honestly would work a lot better as a new ticket :)