Merge pull request #261 from Yoast/feature/fix-runtime-deprecations-php-8.5

jrfnl · web-flow · commit 002a8500063f · 2025-08-10T06:16:45.000+02:00
PHP 8.5 | Tests: prevent deprecation notice for Reflection*::setAccessible()
diff --git a/src/Helpers/AssertAttributeHelper.php b/src/Helpers/AssertAttributeHelper.php
@@ -49,7 +49,7 @@ trait AssertAttributeHelper {
 	public static function getProperty( $objInstance, $propertyName ) {
 		$reflect  = new ReflectionObject( $objInstance );
 		$property = $reflect->getProperty( $propertyName );
-		$property->setAccessible( true );
+		( \PHP_VERSION_ID < 80100 ) && $property->setAccessible( true );
 
 		return $property;
 	}

Original file line number	Diff line number	Diff line change
`@@ -49,7 +49,7 @@ trait AssertAttributeHelper {`
`49`	`49`	`public static function getProperty( $objInstance, $propertyName ) {`
`50`	`50`	`$reflect = new ReflectionObject( $objInstance );`
`51`	`51`	`$property = $reflect->getProperty( $propertyName );`
`52`		`- $property->setAccessible( true );`
	`52`	`+ ( \PHP_VERSION_ID < 80100 ) && $property->setAccessible( true );`
`53`	`53`
`54`	`54`	`return $property;`
`55`	`55`	`}`