-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check Hash DCP charset UTF-8 problem #248
Comments
Thanks for the report @JeromeLesaint. Is that a Windows specific issue? We had case in the past where we had to replace utf-8 by utf-8-sig if I remember correctly. |
Thanks, it's not on windows but on linux (Ubuntu). It's a french installation of linux. And the terminal is on utf-8. I replace decode('utf-8') with decode() and it seems to be work. Nevertheless, i have another problem with mountpoints, filesystems in linux who disturbing the verification. I can try utf8-sig two. Thanks, Best regards |
Interesting, I don't think we have seen such issues on Linux, is that happening all the time or on specifics DCP? Might be useful if you could share privately some of the examples indeed. I don't believe utf8-sig will help you there then. But regardless, I think you are correct that the utf8 decode is not correct here. |
Which Python version do you use by the way? |
Python 3.10 and hash checking fail rather on large files |
hi,
Sometimes, hash of assets aren't correct because in calculation of hash you use a decode("utf-8") at the end (file.py: l 208)
We have made a lot of verifications with the script and DCP-o-Matic.
if you want we have several examples.
Is that possible to modify and put charset in settings of dcp check ?
Thanks a lot,
Best regards,
The text was updated successfully, but these errors were encountered: