Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check Hash DCP charset UTF-8 problem #248

Open
JeromeLesaint opened this issue Jun 28, 2024 · 5 comments
Open

Check Hash DCP charset UTF-8 problem #248

JeromeLesaint opened this issue Jun 28, 2024 · 5 comments

Comments

@JeromeLesaint
Copy link

hi,

Sometimes, hash of assets aren't correct because in calculation of hash you use a decode("utf-8") at the end (file.py: l 208)

We have made a lot of verifications with the script and DCP-o-Matic.

if you want we have several examples.

Is that possible to modify and put charset in settings of dcp check ?

Thanks a lot,

Best regards,

@remia
Copy link
Collaborator

remia commented Jul 1, 2024

Thanks for the report @JeromeLesaint. Is that a Windows specific issue? We had case in the past where we had to replace utf-8 by utf-8-sig if I remember correctly.

@JeromeLesaint
Copy link
Author

Thanks for the report @JeromeLesaint. Is that a Windows specific issue? We had case in the past where we had to replace utf-8 by utf-8-sig if I remember correctly.

Thanks, it's not on windows but on linux (Ubuntu). It's a french installation of linux. And the terminal is on utf-8. I replace decode('utf-8') with decode() and it seems to be work. Nevertheless, i have another problem with mountpoints, filesystems in linux who disturbing the verification. I can try utf8-sig two.

Thanks,

Best regards

@remia
Copy link
Collaborator

remia commented Jul 2, 2024

Interesting, I don't think we have seen such issues on Linux, is that happening all the time or on specifics DCP? Might be useful if you could share privately some of the examples indeed. I don't believe utf8-sig will help you there then.

But regardless, I think you are correct that the utf8 decode is not correct here.

@remia
Copy link
Collaborator

remia commented Jul 2, 2024

Which Python version do you use by the way?

@JeromeLesaint
Copy link
Author

Python 3.10 and hash checking fail rather on large files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants