Skip to content

Bug: jsonschema.compat #149

Open
Open
@peterdudfield

Description

ModuleNotFoundError: No module named 'jsonschema.compat

Jsonschema has a new version out, where this does not exist, and causes an error.

https://github.com/Yelp/swagger_spec_validator/blob/master/swagger_spec_validator/ref_validators.py#L14

See error more detail here

Activity

tirkarthi

tirkarthi commented on Sep 30, 2021

@tirkarthi

Given that this project supports 2.7 and jsonschema 4.0 drop support for 2.7 it makes sense to pin the version number in setup.py .

tirkarthi

tirkarthi commented on Sep 30, 2021

@tirkarthi
peterdudfield

peterdudfield commented on Sep 30, 2021

@peterdudfield
Author

so maybe #148 this the fix do - just pin it in the requirements? But this doesnt seem so nice a solution

tirkarthi

tirkarthi commented on Sep 30, 2021

@tirkarthi

This seems to be an issue with python_requires being not honored. This is fixed in python-jsonschema/jsonschema@e61dcbc . There is also 4.0.1 tagged with the commit https://github.com/Julian/jsonschema/releases/tag/v4.0.1 . So probably once 4.0.0 is yanked with the fixed version (4.0.1) in PyPI tools will continue to pull jsonschema < 4.0.0 automatically.

tirkarthi

tirkarthi commented on Sep 30, 2021

@tirkarthi

Sorry, I was wrong here. It seems the version for jsonschema needs to be pinned here or to fix jsonschema.compat usage netbox-community/netbox#7401

uoxiu

uoxiu commented on Oct 5, 2021

@uoxiu

Yep, swagger_spec_validator should be fixed to work with jsonschema==4.x or set in setup.py max version 3.x

temporary fix is to install manually version 3.x pip install jsonschema==3.2.0

peterdudfield

peterdudfield commented on Oct 5, 2021

@peterdudfield
Author

#146 this is a good solution - using 'six'

leplatrem

leplatrem commented on Jan 5, 2022

@leplatrem

What is the status of this issue?

peterdudfield

peterdudfield commented on Jan 5, 2022

@peterdudfield
Author

I think it go fixed in 734c7e1#diff-f63c3ee26a4134e668551fb48835df29afe314537b277b8ffe33de979262210b
and all unittest tests pass with jsonschema=4.3.3

So I reckon this issue can be closed

1 remaining item

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      Bug: jsonschema.compat · Issue #149 · Yelp/swagger_spec_validator