Skip to content

Commit c24a5e2

Browse files
committed
KAFKA-24599: revert deletion of test_kafka_consumer_offsets_for_time_old since it won't get run for our version anyway; increase timeout on assert_message_count to avoid test failures
1 parent 31a0d2c commit c24a5e2

File tree

2 files changed

+10
-1
lines changed

2 files changed

+10
-1
lines changed

test/test_consumer_integration.py

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -758,6 +758,15 @@ def test_kafka_consumer_offsets_search_many_partitions(kafka_consumer, kafka_pro
758758
}
759759

760760

761+
@pytest.mark.skipif(env_kafka_version() >= (0, 10, 1), reason="Requires KAFKA_VERSION < 0.10.1")
762+
def test_kafka_consumer_offsets_for_time_old(kafka_consumer, topic):
763+
consumer = kafka_consumer
764+
tp = TopicPartition(topic, 0)
765+
766+
with pytest.raises(UnsupportedVersionError):
767+
consumer.offsets_for_times({tp: int(time.time())})
768+
769+
761770
@pytest.mark.skipif(env_kafka_version() < (0, 10, 1), reason="Requires KAFKA_VERSION >= 0.10.1")
762771
def test_kafka_consumer_offsets_for_times_errors(kafka_consumer_factory, topic):
763772
consumer = kafka_consumer_factory(fetch_max_wait_ms=200,

test/test_failover_integration.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -208,7 +208,7 @@ def _kill_leader(self, topic, partition):
208208
broker.close()
209209
return broker
210210

211-
def assert_message_count(self, topic, check_count, timeout=10,
211+
def assert_message_count(self, topic, check_count, timeout=25,
212212
partitions=None, at_least=False):
213213
hosts = ','.join(['%s:%d' % (broker.host, broker.port)
214214
for broker in self.brokers])

0 commit comments

Comments
 (0)