Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

not to use replacen() in AggegationConditionCompiler.tokenize() function #1278

Closed
hach1yon opened this issue Feb 12, 2024 · 1 comment · Fixed by #1288
Closed

not to use replacen() in AggegationConditionCompiler.tokenize() function #1278

hach1yon opened this issue Feb 12, 2024 · 1 comment · Fixed by #1288
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers
Milestone

Comments

@hach1yon
Copy link
Collaborator

This issue is a sub issue of #787 .

AggegationConditionCompiler.tokenize() function utilizes replacen() in the while loop. A new string instance would be created in hhe function replacen() so we can reduce memory usage if we replace replacen() with something.

AggegationConditionCompiler.tokenize() use replacen() in order to memorize how far the tokenization has progressed. I think this can be replaced with index access.

@hach1yon hach1yon added enhancement New feature or request good first issue Good for newcomers labels Feb 12, 2024
@YamatoSecurity YamatoSecurity added this to the v2.14.0 milestone Feb 27, 2024
@YamatoSecurity
Copy link
Collaborator

@fukusuket is interested in this issue so I have assigned him.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
3 participants