Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How can we send UCrop features through UCrop.options? #126

Closed
omegasoft7 opened this issue May 29, 2016 · 4 comments
Closed

How can we send UCrop features through UCrop.options? #126

omegasoft7 opened this issue May 29, 2016 · 4 comments

Comments

@omegasoft7
Copy link

Hi

We are trying to use your lib in our project. We are sending UCrop.options and then proceeding with Cropping. But problem is there are some features that we cant set on UCrop.option some features like:

UCrop.of(sourceUri, destinationUri)
.withAspectRatio(16, 9) <------
.withMaxResultSize(maxWidth, maxHeight) <------
.start(context);

Do you have a solution to pass those parameters through UCrop.options?

@shliama
Copy link
Contributor

shliama commented May 31, 2016

You cannot do this at the moment. I've designed Options class to handle secondary configuration parameters. If you really need this feature - it would be faster to fork and edit the UCrop class.
Otherwise, you can wait and I'll add this feature in the next update.

@omegasoft7
Copy link
Author

Will wait for that. Thanks

@shliama
Copy link
Contributor

shliama commented Jun 27, 2016

@omegasoft7 please check version 2.1.0 - I've added API so you can set those properties via both UCrop & Options classes.

@omegasoft7
Copy link
Author

@shliama Thanks That is great

@shliama shliama closed this as completed Jun 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants