From e18b177436eb3c5dcd84ef60671ec9c60d3da193 Mon Sep 17 00:00:00 2001 From: Andy Pan Date: Thu, 13 Feb 2020 21:54:15 +0800 Subject: [PATCH] trifle: remove unreachable and useless code --- eventloop_unix.go | 6 +++--- eventloop_windows.go | 6 +++--- gnet_test.go | 1 - 3 files changed, 6 insertions(+), 7 deletions(-) diff --git a/eventloop_unix.go b/eventloop_unix.go index d40eb2a76..5d8a5f67c 100644 --- a/eventloop_unix.go +++ b/eventloop_unix.go @@ -163,9 +163,9 @@ func (el *eventloop) loopCloseConn(c *conn, err error) error { } func (el *eventloop) loopWake(c *conn) error { - if co, ok := el.connections[c.fd]; !ok || co != c { - return nil // ignore stale wakes. - } + //if co, ok := el.connections[c.fd]; !ok || co != c { + // return nil // ignore stale wakes. + //} out, action := el.eventHandler.React(nil, c) if out != nil { frame, _ := el.codec.Encode(c, out) diff --git a/eventloop_windows.go b/eventloop_windows.go index 68e97a9a8..010acb550 100644 --- a/eventloop_windows.go +++ b/eventloop_windows.go @@ -180,9 +180,9 @@ func (el *eventloop) loopError(c *stdConn, err error) (e error) { } func (el *eventloop) loopWake(c *stdConn) error { - if _, ok := el.connections[c]; !ok { - return nil // ignore stale wakes. - } + //if co, ok := el.connections[c]; !ok || co != c { + // return nil // ignore stale wakes. + //} out, action := el.eventHandler.React(nil, c) if out != nil { frame, _ := el.codec.Encode(c, out) diff --git a/gnet_test.go b/gnet_test.go index da091eb98..ee1be4fd1 100644 --- a/gnet_test.go +++ b/gnet_test.go @@ -593,7 +593,6 @@ func (t *testWakeConnServer) OnOpened(c Conn) (out []byte, action Action) { return } func (t *testWakeConnServer) OnClosed(c Conn, err error) (action Action) { - _ = t.conn.Wake() action = Shutdown return }