-
-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Subpar performance when running gvim or emacs #670
Comments
On a 1080p screen with a What a really odd way of painting the screen! So the good news is that I have a workaround: XPRA_FORCE_BATCH=1 xpra start ... Will start the server with force-batch mode, which means that even when things are going well (no pixel backlog or network congestion) we will wait before encoding the pixels, which allows us to batch them up together. cesarkawakami: does that improve things for you? As for a more proper fix for this: I'm not too sure how to go about it. Another approach would be to enable batching when we detect a damage storm like this one. Which is probably the better option, but may not be suitable for a 0.14.x backport. |
The slightly better solution implemented in r7516 is to turn on damage batching if we find more than 5 damage events in the last 10 milliseconds. cesarkawakami: do both solutions work for you? Any other ideas? FYI: using other encodings, even video encodings, seems to work just as well: the small updates get sent as rgb anyway. Note: emacs just sitting idle will repaint the cursor even when it isn't focused or blinking, causing 4 damage events as it repaints each line around the hollow cursor individually! |
2014-09-05 18:41:58: cesarkawakami2 commented
|
Sorry about that, there were many spam accounts created yesterday, and I must have deleted your account by mistake.
That's odd, they make a very noticeable difference on my test setup. |
2014-09-08 04:38:39: totaam commented
|
2014-09-08 18:15:12: cesarkawakami2 uploaded file
|
2014-09-08 18:30:45: cesarkawakami2 commented
|
2014-09-08 18:33:13: cesarkawakami2 uploaded file
|
2014-09-08 18:33:30: cesarkawakami2 commented
|
2014-09-08 19:52:23: totaam commented
|
The patch breaks "video regions" (which needs to modify the region), and cesarkawakami also reported "random spinfreezes"... so I think we should forget about this one. |
FYI:
|
2015-01-06 06:47:54: antoine uploaded file
|
Thanks to the work on #760, I fixed a bug in the damage region merging code (fixed in 8374). This is included in the upcoming 0.14.16 The repaints now look like this If you can reproduce the problem, please include a screenshot using: XPRA_OPENGL_PAINT_BOX=1 xpra attach ... As per #760. This may show us what is going on in more detail. |
Not heard back, I assume this is fixed. Closing. |
Issue migrated from trac ticket # 670
component: core | priority: critical | resolution: fixed | keywords: performance paint gvim emacs damage storm
2014-09-04 21:02:08: cesarkawakami created the issue
The text was updated successfully, but these errors were encountered: