Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

key repeat not firing #1724

Closed
totaam opened this issue Dec 15, 2017 · 4 comments
Closed

key repeat not firing #1724

totaam opened this issue Dec 15, 2017 · 4 comments

Comments

@totaam
Copy link
Collaborator

totaam commented Dec 15, 2017

Issue migrated from trac ticket # 1724

component: keyboard | priority: major | resolution: fixed

2017-12-15 06:35:55: antoine created the issue


It's been broken for a while.
The "keyboard helper" doesn't set the key repeat delay and interval, so we never schedule the key repeat timer.

Things have been working well enough and no-one noticed!

@totaam
Copy link
Collaborator Author

totaam commented Dec 15, 2017

2017-12-15 06:41:53: antoine commented


Fixed in r17649.

Not sure if we should bother backporting this, added to Versions PendingFixes

@totaam
Copy link
Collaborator Author

totaam commented Dec 15, 2017

2017-12-15 06:46:50: antoine changed status from new to closed

@totaam
Copy link
Collaborator Author

totaam commented Dec 15, 2017

2017-12-15 06:46:50: antoine set resolution to fixed

@totaam
Copy link
Collaborator Author

totaam commented Dec 15, 2017

2017-12-15 06:46:50: antoine commented


GTK triggers key repeat events anyway, so we send key events that have the same effect as the "key-repeat" packets.

r17650 + r17651 just rips it all out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant