Hitting 'Error during scrolling detection!'s with 1.05 & 1.06 clients with opengl enabled.

[totaam]

Issue migrated from trac ticket # 1508

component: server | priority: major | resolution: fixed

2017-04-25 02:57:39: afarr created the issue

---

Testing against a 1.0.6 r15707 fedora 25 server using either the OSX 1.0.6 r 15627 client from your beta directory (dmg) (10.12) and 1.0.5 15455 win client from your dists directory (win 10).

When connecting with opengl enabled (with a non-Intel gpu on the OSX machine and forcing the opengl on with the Intel Iris video card on the Win 10 machine) I am seeing the following errors server side.

With the OSX client with opengl on by default... (OpenGL enabled with ATI Radeon HD - FirePro D300 OpenGL Engine).

2017-04-24 18:37:44,967 xpra is ready.
2017-04-24 18:37:52,561 New tcp connection received from 10.0.4.80:58630
2017-04-24 18:37:52,578 Handshake complete; enabling connection
2017-04-24 18:37:52,675 Python/Gtk2 Mac OS X 10.12 client version 1.0.6-15627 32-bit
2017-04-24 18:37:52,676  connected from 'Max-Trashcan.local' as 'maint'
2017-04-24 18:37:52,677  automatic picture encoding enabled
2017-04-24 18:37:52,677  also available:
2017-04-24 18:37:52,678   h264, vp9, vp8, png, png/P, png/L, rgb24, jpeg, rgb32
2017-04-24 18:37:52,679  client root window size is 3840x2160 with 1 display:
2017-04-24 18:37:52,679   max-trashcan.local (1354x762 mm - DPI: 72x72) workarea: 3840x2054 at 0x23
2017-04-24 18:37:52,679     monitor 1
2017-04-24 18:37:52,681 temporarily switching to 5680x1440 as a Xinerama workaround
2017-04-24 18:37:52,698 server virtual display now set to 3840x2160
2017-04-24 18:37:52,708 setting keyboard layout to 'us'
2017-04-24 18:37:52,768 DPI set to 72 x 72
2017-04-24 18:37:52,816 client 1: Attached to tcp:10.0.32.138 (press Control-C to detach)
2017-04-24 18:37:53,319 using pulseaudio device:
2017-04-24 18:37:53,319  'Monitor of Xpra Speaker'
2017-04-24 18:37:54,554 the remote printer  has been configured
2017-04-24 18:37:55,027 sound source using audio codec flac
2017-04-24 18:37:55,027 sound source using container format ogg
2017-04-24 18:38:03,168 Error during scrolling detection!
Traceback (most recent call last):
  File "/usr/lib64/python2.7/site-packages/xpra/server/window/window_video_source.py", line 1644, in do_video_encode
    csums = CRC_Image(img_data, w, h, stride)
  File "xpra/server/window/motion.pyx", line 59, in xpra.server.window.motion.CRC_Image (xpra/server/window/motion.c:1522)
AssertionError: buffer is too small for 4472x360
2017-04-24 18:38:03,176 Error during encoding:
Traceback (most recent call last):
  File "/usr/lib64/python2.7/site-packages/xpra/server/source.py", line 2211, in encode_loop
    fn_and_args[1](*fn_and_args[2:])
  File "/usr/lib64/python2.7/site-packages/xpra/server/window/window_source.py", line 1467, in make_data_packet_cb
    packet = self.make_data_packet(damage_time, process_damage_time, image, coding, sequence, options, flush)
  File "/usr/lib64/python2.7/site-packages/xpra/server/window/window_source.py", line 1817, in make_data_packet
    ret = encoder(coding, image, options)
  File "/usr/lib64/python2.7/site-packages/xpra/server/window/window_video_source.py", line 1591, in video_encode
    return self.do_video_encode(encoding, image, options)
  File "/usr/lib64/python2.7/site-packages/xpra/server/window/window_video_source.py", line 1674, in do_video_encode
    scroll_data.free()
NameError: global name 'scroll_data' is not defined
2017-04-24 18:38:03,224 Error during scrolling detection!
Traceback (most recent call last):
  File "/usr/lib64/python2.7/site-packages/xpra/server/window/window_video_source.py", line 1644, in do_video_encode
    csums = CRC_Image(img_data, w, h, stride)
  File "xpra/server/window/motion.pyx", line 59, in xpra.server.window.motion.CRC_Image (xpra/server/window/motion.c:1522)
AssertionError: buffer is too small for 4472x360
2017-04-24 18:38:03,227 Error during encoding:
Traceback (most recent call last):
  File "/usr/lib64/python2.7/site-packages/xpra/server/source.py", line 2211, in encode_loop
    fn_and_args[1](*fn_and_args[2:])
  File "/usr/lib64/python2.7/site-packages/xpra/server/window/window_source.py", line 1467, in make_data_packet_cb
    packet = self.make_data_packet(damage_time, process_damage_time, image, coding, sequence, options, flush)
  File "/usr/lib64/python2.7/site-packages/xpra/server/window/window_source.py", line 1817, in make_data_packet
    ret = encoder(coding, image, options)
  File "/usr/lib64/python2.7/site-packages/xpra/server/window/window_video_source.py", line 1591, in video_encode
    return self.do_video_encode(encoding, image, options)
  File "/usr/lib64/python2.7/site-packages/xpra/server/window/window_video_source.py", line 1674, in do_video_encode
    scroll_data.free()
NameError: global name 'scroll_data' is not defined
2017-04-24 18:38:03,289 Error during scrolling detection!
Traceback (most recent call last):
  File "/usr/lib64/python2.7/site-packages/xpra/server/window/window_video_source.py", line 1644, in do_video_encode
    csums = CRC_Image(img_data, w, h, stride)
  File "xpra/server/window/motion.pyx", line 59, in xpra.server.window.motion.CRC_Image (xpra/server/window/motion.c:1522)
AssertionError: buffer is too small for 4472x360
2017-04-24 18:38:03,291 Error during encoding:
Traceback (most recent call last):
  File "/usr/lib64/python2.7/site-packages/xpra/server/source.py", line 2211, in encode_loop
    fn_and_args[1](*fn_and_args[2:])
  File "/usr/lib64/python2.7/site-packages/xpra/server/window/window_source.py", line 1467, in make_data_packet_cb
    packet = self.make_data_packet(damage_time, process_damage_time, image, coding, sequence, options, flush)
  File "/usr/lib64/python2.7/site-packages/xpra/server/window/window_source.py", line 1817, in make_data_packet
    ret = encoder(coding, image, options)
  File "/usr/lib64/python2.7/site-packages/xpra/server/window/window_video_source.py", line 1591, in video_encode
    return self.do_video_encode(encoding, image, options)
  File "/usr/lib64/python2.7/site-packages/xpra/server/window/window_video_source.py", line 1674, in do_video_encode
    scroll_data.free()
NameError: global name 'scroll_data' is not defined
2017-04-24 18:38:03,355 Error during scrolling detection!
Traceback (most recent call last):
  File "/usr/lib64/python2.7/site-packages/xpra/server/window/window_video_source.py", line 1644, in do_video_encode
    csums = CRC_Image(img_data, w, h, stride)
  File "xpra/server/window/motion.pyx", line 59, in xpra.server.window.motion.CRC_Image (xpra/server/window/motion.c:1522)
AssertionError: buffer is too small for 4472x360
2017-04-24 18:38:03,356 Error during encoding:
Traceback (most recent call last):
  File "/usr/lib64/python2.7/site-packages/xpra/server/source.py", line 2211, in encode_loop
    fn_and_args[1](*fn_and_args[2:])
  File "/usr/lib64/python2.7/site-packages/xpra/server/window/window_source.py", line 1467, in make_data_packet_cb
    packet = self.make_data_packet(damage_time, process_damage_time, image, coding, sequence, options, flush)
  File "/usr/lib64/python2.7/site-packages/xpra/server/window/window_source.py", line 1817, in make_data_packet
    ret = encoder(coding, image, options)
  File "/usr/lib64/python2.7/site-packages/xpra/server/window/window_video_source.py", line 1591, in video_encode
    return self.do_video_encode(encoding, image, options)
  File "/usr/lib64/python2.7/site-packages/xpra/server/window/window_video_source.py", line 1674, in do_video_encode
    scroll_data.free()
NameError: global name 'scroll_data' is not defined
2017-04-24 18:38:03,421 Error during scrolling detection!
Traceback (most recent call last):
  File "/usr/lib64/python2.7/site-packages/xpra/server/window/window_video_source.py", line 1644, in do_video_encode
    csums = CRC_Image(img_data, w, h, stride)
  File "xpra/server/window/motion.pyx", line 59, in xpra.server.window.motion.CRC_Image (xpra/server/window/motion.c:1522)
AssertionError: buffer is too small for 4472x360
2017-04-24 18:38:03,422 Error during encoding:
Traceback (most recent call last):
  File "/usr/lib64/python2.7/site-packages/xpra/server/source.py", line 2211, in encode_loop
    fn_and_args[1](*fn_and_args[2:])
  File "/usr/lib64/python2.7/site-packages/xpra/server/window/window_source.py", line 1467, in make_data_packet_cb
    packet = self.make_data_packet(damage_time, process_damage_time, image, coding, sequence, options, flush)
  File "/usr/lib64/python2.7/site-packages/xpra/server/window/window_source.py", line 1817, in make_data_packet
    ret = encoder(coding, image, options)
  File "/usr/lib64/python2.7/site-packages/xpra/server/window/window_video_source.py", line 1591, in video_encode
    return self.do_video_encode(encoding, image, options)
  File "/usr/lib64/python2.7/site-packages/xpra/server/window/window_video_source.py", line 1674, in do_video_encode
    scroll_data.free()
NameError: global name 'scroll_data' is not defined
2017-04-24 18:38:03,485 Error during scrolling detection!
Traceback (most recent call last):
  File "/usr/lib64/python2.7/site-packages/xpra/server/window/window_video_source.py", line 1644, in do_video_encode
    csums = CRC_Image(img_data, w, h, stride)
  File "xpra/server/window/motion.pyx", line 59, in xpra.server.window.motion.CRC_Image (xpra/server/window/motion.c:1522)
AssertionError: buffer is too small for 4472x360
2017-04-24 18:38:03,486 Error during encoding:
Traceback (most recent call last):
  File "/usr/lib64/python2.7/site-packages/xpra/server/source.py", line 2211, in encode_loop
    fn_and_args[1](*fn_and_args[2:])
  File "/usr/lib64/python2.7/site-packages/xpra/server/window/window_source.py", line 1467, in make_data_packet_cb
    packet = self.make_data_packet(damage_time, process_damage_time, image, coding, sequence, options, flush)
  File "/usr/lib64/python2.7/site-packages/xpra/server/window/window_source.py", line 1817, in make_data_packet
    ret = encoder(coding, image, options)
  File "/usr/lib64/python2.7/site-packages/xpra/server/window/window_video_source.py", line 1591, in video_encode
    return self.do_video_encode(encoding, image, options)
  File "/usr/lib64/python2.7/site-packages/xpra/server/window/window_video_source.py", line 1674, in do_video_encode
    scroll_data.free()
NameError: global name 'scroll_data' is not defined
2017-04-24 18:38:03,554 Error during scrolling detection!
Traceback (most recent call last):
  File "/usr/lib64/python2.7/site-packages/xpra/server/window/window_video_source.py", line 1644, in do_video_encode
    csums = CRC_Image(img_data, w, h, stride)
  File "xpra/server/window/motion.pyx", line 59, in xpra.server.window.motion.CRC_Image (xpra/server/window/motion.c:1522)
AssertionError: buffer is too small for 4472x360
2017-04-24 18:38:03,556 Error during encoding:
Traceback (most recent call last):
  File "/usr/lib64/python2.7/site-packages/xpra/server/source.py", line 2211, in encode_loop
    fn_and_args[1](*fn_and_args[2:])
  File "/usr/lib64/python2.7/site-packages/xpra/server/window/window_source.py", line 1467, in make_data_packet_cb
    packet = self.make_data_packet(damage_time, process_damage_time, image, coding, sequence, options, flush)
  File "/usr/lib64/python2.7/site-packages/xpra/server/window/window_source.py", line 1817, in make_data_packet
    ret = encoder(coding, image, options)
  File "/usr/lib64/python2.7/site-packages/xpra/server/window/window_video_source.py", line 1591, in video_encode
    return self.do_video_encode(encoding, image, options)
  File "/usr/lib64/python2.7/site-packages/xpra/server/window/window_video_source.py", line 1674, in do_video_encode
    scroll_data.free()
NameError: global name 'scroll_data' is not defined

Don't see the error at all with Intel Iris if not forcing opengl.

Forcing the opengl I see what looks like the same error. A clip of the errors:

2017-04-24 16:56:58,031 Error during encoding:
Traceback (most recent call last):
  File "/usr/lib64/python2.7/site-packages/xpra/server/source.py", line 2211, in encode_loop
    fn_and_args[1](*fn_and_args[2:])
  File "/usr/lib64/python2.7/site-packages/xpra/server/window/window_source.py", line 1467, in make_data_packet_cb
    packet = self.make_data_packet(damage_time, process_damage_time, image, coding, sequence, options, flush)
  File "/usr/lib64/python2.7/site-packages/xpra/server/window/window_source.py", line 1817, in make_data_packet
    ret = encoder(coding, image, options)
  File "/usr/lib64/python2.7/site-packages/xpra/server/window/window_video_source.py", line 1591, in video_encode
    return self.do_video_encode(encoding, image, options)
  File "/usr/lib64/python2.7/site-packages/xpra/server/window/window_video_source.py", line 1674, in do_video_encode
    scroll_data.free()
NameError: global name 'scroll_data' is not defined
2017-04-24 16:56:58,067 Error during scrolling detection!
Traceback (most recent call last):
  File "/usr/lib64/python2.7/site-packages/xpra/server/window/window_video_source.py", line 1644, in do_video_encode
    csums = CRC_Image(img_data, w, h, stride)
  File "xpra/server/window/motion.pyx", line 59, in xpra.server.window.motion.CRC_Image (xpra/server/window/motion.c:1522)
AssertionError: buffer is too small for 4472x360
2017-04-24 16:56:58,068 Error during encoding:
Traceback (most recent call last):
  File "/usr/lib64/python2.7/site-packages/xpra/server/source.py", line 2211, in encode_loop
    fn_and_args[1](*fn_and_args[2:])
  File "/usr/lib64/python2.7/site-packages/xpra/server/window/window_source.py", line 1467, in make_data_packet_cb
    packet = self.make_data_packet(damage_time, process_damage_time, image, coding, sequence, options, flush)
  File "/usr/lib64/python2.7/site-packages/xpra/server/window/window_source.py", line 1817, in make_data_packet
    ret = encoder(coding, image, options)
  File "/usr/lib64/python2.7/site-packages/xpra/server/window/window_video_source.py", line 1591, in video_encode
    return self.do_video_encode(encoding, image, options)
  File "/usr/lib64/python2.7/site-packages/xpra/server/window/window_video_source.py", line 1674, in do_video_encode
    scroll_data.free()
NameError: global name 'scroll_data' is not defined

[totaam]

2017-04-25 04:16:14: antoine changed owner from antoine to afarr

[totaam]

2017-04-25 04:16:14: antoine commented

---

Good catch.

• AssertionError: buffer is too small for 4472x360 is probably fixed in 15709
• NameError: global name 'scroll_data' is not defined only fired when another error occurred (as per above), but 15708 should take care of this one.

FYI: this code only fires when the client uses opengl because the scrolling paint code is only implemented in the opengl backend (see #1232#comment:19)

[totaam]

2017-07-14 17:44:42: antoine changed status from new to closed

[totaam]

2017-07-14 17:44:42: antoine set resolution to fixed