Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyboard layout sync and managers #1234

Closed
totaam opened this issue Jun 18, 2016 · 13 comments
Closed

Keyboard layout sync and managers #1234

totaam opened this issue Jun 18, 2016 · 13 comments

Comments

@totaam
Copy link
Collaborator

totaam commented Jun 18, 2016

Issue migrated from trac ticket # 1234

component: client | priority: minor | resolution: fixed | keywords: keyboard layout switching X11

2016-06-18 09:50:31: psycho_zs created the issue


With global layout mode (X default, when no layout tool is used) layout can get out of sync: when xpra window is in focus, layout switches both on client and on server. When xpra window is out of focus, layout is only switched on client. When xpra recieves focus again, layouts can be inverted between client and server.

When using per-app mode (i.e. gxkb provides that, other tools like qxkb, gnome-settings-daemon can be configured also), layout is remembered per application (supposedly by PID). This works fine (omitting that all xpra windows get the same layout, but that is expected) for some time, until at some point it gets out of sync and becomes inverted also. Perhaps, when xpra window gains or looses focus it may or may not catch layout change.

I haven't tested any per-window mode, but supposedly it should have similar problem to per-app mode.

So, the main problem is that layout on server can become different than layout on client. Switching several times while xpra window is in focus re-syncs layouts.
Also, witching layouts by gxkb tray icon, even when xpra window is in focus, does not affect layout on server.

@totaam
Copy link
Collaborator Author

totaam commented Jun 18, 2016

2016-06-18 10:33:23: antoine changed owner from antoine to psycho_zs

@totaam
Copy link
Collaborator Author

totaam commented Jun 18, 2016

2016-06-18 10:33:23: antoine changed component from android to client

@totaam
Copy link
Collaborator Author

totaam commented Jun 18, 2016

2016-06-18 10:33:23: antoine commented


We detect that the layout has changed using keys-changed signal of gtk.gdk.Keymap, maybe it isn't firing when it should. We could try to use the X11 hooks to make sure we get all such events.

Split from #1027 which is for win32.

Can you post the -d keyboard output of such events?

@totaam
Copy link
Collaborator Author

totaam commented Jun 18, 2016

2016-06-18 10:39:57: psycho_zs uploaded file log.txt (136.4 KiB)

@totaam
Copy link
Collaborator Author

totaam commented Jun 18, 2016

2016-06-18 10:43:39: psycho_zs commented


Attached the client terminal output. Attached to server, started leafpad, typed something in 'us' layout, switched to 'ru', typed again, changed to other window (local with 'en' layout), changed back to xpra leafpad window which should have 'ru' layout, typed, got latin characters. Gxkb icon showed ru layout for this window.

@totaam
Copy link
Collaborator Author

totaam commented Jul 12, 2016

2016-07-12 17:51:51: antoine commented


Milestone renamed

@totaam
Copy link
Collaborator Author

totaam commented Aug 21, 2016

2016-08-21 10:55:50: antoine commented


Milestone renamed

@totaam
Copy link
Collaborator Author

totaam commented Dec 16, 2016

2016-12-16 19:46:36: antoine commented


Maybe #1380 will help?

@totaam
Copy link
Collaborator Author

totaam commented Dec 23, 2016

2016-12-23 19:13:05: psycho_zs changed status from new to closed

@totaam
Copy link
Collaborator Author

totaam commented Dec 23, 2016

2016-12-23 19:13:05: psycho_zs set resolution to fixed

@totaam
Copy link
Collaborator Author

totaam commented Dec 23, 2016

2016-12-23 19:13:05: psycho_zs commented


Tested in 2.0-20161223r14589-1. Layout seem to stay in sync with what is currently selected locally on the client.
Fixed, thanks!

@totaam totaam closed this as completed Dec 23, 2016
@totaam
Copy link
Collaborator Author

totaam commented Jan 23, 2017

2017-01-23 07:36:08: antoine changed title from Keyborad layout sync and managers to Keyboard layout sync and managers

@totaam
Copy link
Collaborator Author

totaam commented Jan 23, 2017

2017-01-23 07:36:08: antoine commented


(typo in title)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant