Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve package eth/filter #491

Merged
merged 7 commits into from
Mar 18, 2024
Merged

improve package eth/filter #491

merged 7 commits into from
Mar 18, 2024

Conversation

gzliudan
Copy link
Collaborator

@gzliudan gzliudan commented Mar 14, 2024

Proposed changes

Picked some PRs about package filter from ethereum to enhance the solution of #457:

2018-05-09 PR #16682: eth/filter: check nil pointer when unsubscribe
2018-06-14 PR #16920: eth/filters: make filterLogs func more readable
2018-07-12 PR #16734: accounts, eth, les: blockhash based filtering on all code paths
2018-07-24 PR #17234: eth/filters: improve error message for invalid filter topics
2018-07-30 PR #17267: all: simplify switches
2018-07-31 PR #17284: eth/filters: fix the block range assignment for log filter
2019-07-17 PR #19670: all: replace fmt.Print* calls with t.Log* in tests

Types of changes

What types of changes does your code introduce to XDC network?
Put an in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)
  • Regular KTLO or any of the maintaince work. e.g code style
  • CICD Improvement

Impacted Components

Which part of the codebase this PR will touch base on,

Put an in the boxes that apply

  • Consensus
  • Account
  • Network
  • Geth
  • Smart Contract
  • External components
  • Not sure (Please specify below)

Checklist

Put an in the boxes once you have confirmed below actions (or provide reasons on not doing so) that

  • This PR has sufficient test coverage (unit/integration test) OR I have provided reason in the PR description for not having test coverage
  • Provide an end-to-end test plan in the PR description on how to manually test it on the devnet/testnet.
  • Tested the backwards compatibility.
  • Tested with XDC nodes running this version co-exist with those running the previous version.
  • Relevant documentation has been updated as part of this PR
  • N/A

@gzliudan gzliudan requested a review from liam-lai March 14, 2024 12:00
@gzliudan gzliudan changed the title update package eth/filter improve package eth/filter Mar 14, 2024
@gzliudan gzliudan force-pushed the filter branch 3 times, most recently from 9b10090 to 84bd2b4 Compare March 15, 2024 13:10
@gzliudan gzliudan merged commit 4d8effe into XinFinOrg:dev-upgrade Mar 18, 2024
16 checks passed
@gzliudan gzliudan deleted the filter branch March 18, 2024 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants