[CIR] Inject AIE dialects into CIR lowering passes

The CIR lowering passes are aware of AIE dialects when going to LLVM dialect or
MLIR standard dialects from aie-opt or aie-translate.
Also expose the --cir-to-llvm pass to aie-opt.

Author: keryell

lib/CIR/CIRToAIEPasses.cpp

@@ -890,6 +890,8 @@ struct CIRToAIEInlineKernelLambda
             .failed())
       call.emitError("CIRToAIEInlineKernelLambdaBase not able to "
                      "inline the lambda call");
+    // Only erase the call since the callee could be used in another
+    // context. Rely later on --symbol-dce pass.
     call.erase();
   }
 

tools/aie-opt/aie-opt.cpp

@@ -28,6 +28,8 @@
 #ifdef CLANGIR_MLIR_FRONTEND
 #include "clang/CIR/Dialect/IR/CIRDialect.h"
 #include "clang/CIR/Dialect/Passes.h"
+#include "clang/CIR/LowerToLLVM.h"
+#include "clang/CIR/LowerToMLIR.h"
 #include "clang/CIR/Passes.h"
 #endif
 
@@ -104,9 +106,13 @@ int main(int argc, char **argv) {
   mlir::registerPass([]() -> std::unique_ptr<mlir::Pass> {
     return cir::createConvertCIRToMLIRPass();
   });
+  mlir::registerPass([]() -> std::unique_ptr<mlir::Pass> {
+    return cir::direct::createConvertCIRToLLVMPass();
+  });
 
   mlir::PassPipelineRegistration<mlir::EmptyPipelineOptions> pipeline(
-      "cir-to-llvm", "", [](mlir::OpPassManager &pm) {
+      "cir-to-llvm", "Full pass pipeline from CIR to LLVM MLIR dialect",
+      [](mlir::OpPassManager &pm) {
         cir::direct::populateCIRToLLVMPasses(pm, /* useCCLowering */ true);
       });
 
@@ -119,6 +125,20 @@ int main(int argc, char **argv) {
   });
 
   mlir::registerTransformsPasses();
+
+  cir::runAtStartOfConvertCIRToMLIRPass([](mlir::ConversionTarget ct) {
+    ct.addLegalDialect<xilinx::AIE::AIEDialect, xilinx::AIEX::AIEXDialect,
+                       xilinx::aievec::aie1::AIEVecAIE1Dialect,
+                       xilinx::aievec::AIEVecDialect>();
+    ct.addLegalOp<mlir::UnrealizedConversionCastOp>();
+  });
+
+  cir::direct::runAtStartOfConvertCIRToLLVMPass([](mlir::ConversionTarget ct) {
+    ct.addLegalDialect<xilinx::AIE::AIEDialect, xilinx::AIEX::AIEXDialect,
+                       xilinx::aievec::aie1::AIEVecAIE1Dialect,
+                       xilinx::aievec::AIEVecDialect>();
+    ct.addLegalOp<mlir::UnrealizedConversionCastOp>();
+  });
 #endif
 
   return failed(

tools/aie-translate/aie-translate.cpp

@@ -110,6 +110,14 @@ int main(int argc, char **argv) {
     ct.addLegalDialect<xilinx::AIE::AIEDialect, xilinx::AIEX::AIEXDialect,
                        xilinx::aievec::aie1::AIEVecAIE1Dialect,
                        xilinx::aievec::AIEVecDialect>();
+    ct.addLegalOp<mlir::UnrealizedConversionCastOp>();
+  });
+
+  cir::direct::runAtStartOfConvertCIRToLLVMPass([](mlir::ConversionTarget ct) {
+    ct.addLegalDialect<xilinx::AIE::AIEDialect, xilinx::AIEX::AIEXDialect,
+                       xilinx::aievec::aie1::AIEVecAIE1Dialect,
+                       xilinx::aievec::AIEVecDialect>();
+    ct.addLegalOp<mlir::UnrealizedConversionCastOp>();
   });
 #endif
   registerToLLVMIRTranslation();