Skip to content

bsp: standalone: Fix -filter in standalone.tcl so that can find TTC2/3 properly #323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 298 commits into
base: master
Choose a base branch
from

Conversation

Tosainu
Copy link

@Tosainu Tosainu commented Nov 15, 2024

Hello. Let me share my patch here. This patch solves the issue of TTC2/3 detection when using the isolation-enabled design.

I sent the same patch to the mailing list, so far no responses though.

Mulagondla, Bharath and others added 30 commits October 4, 2024 19:17
Fix boot device copy optimization control logic by comparing the
reg value properly.

Signed-off-by: Bharath Mulagondla <bharath.mulagondla@amd.com>
Acked-by: Mounika Akula <mounika.akula@amd.com>
ByteAlignedTransfer is not supported on all upcoming device families
consistently. Hence add device specific checks for this functions as
well as the places where Size (in words or bytes) and address alignment
is checked. ByteAlignedTransfer is defeatured on Versal Net. However,
there is a workaround to use this feature by taking care of the
Endianness in user applications. Since secure libraries already
implement this workaround and use this function, the driver will
continue to support the same. ByteAlignedTransfer is supported without
any workarounds on Versal Gen 2.

Signed-off-by: Abin Joseph <abin.joseph@amd.com>
Acked-by: Harini Katakam <harini.katakam@amd.com>
A power rail can be supplied by a regulator from different vendors.  Identify
the vendor by issuing PMBus command IC_DEVICE_ID and select the right power
rail entry in board CDO to match that vendor.

Signed-off-by: Saeed Nowshadi <saeed.nowshadi@amd.com>
Acked-by: Trung N Tran<trung.tran@amd.com>
- Only resume subsystem configuration and requirements during IPU.
- Modifying subsystems is not allowed during IPU, including the default subsystem.

Signed-off-by: Trung tran <trung.tran@amd.com>

Acked-for-series: Sandeep Reddy Ghanapuram <sandeep.reddy-ghanapuram@amd.com>
- Implement handling for updating XPm_MemRegnDevice node types.
- Ensure creation of missing PGGS and GGS type of nodes.
- Ensure creation of missing XPm_Requirement links between devices and subsystems.

Signed-off-by: Trung tran <trung.tran@amd.com>

Acked-for-series: Sandeep Reddy Ghanapuram <sandeep.reddy-ghanapuram@amd.com>
Appended the supporting processors in xilpdi.yaml file

Signed-off-by: Raviteja Ponukupati <raviteja.ponukupati@amd.com>
Acked-by: Mounika Akula <mounika.akula@amd.com>
Added zeroization and saving new key in PPU RAM

Signed-off-by: Preethi Kolli <preethi.kolli@amd.com>
Acked-by: Mounika Akula <mounika.akula@amd.com>
Updated changelog for axicdma,xilsem and few other

Signed-off-by: Kopparapu,Mounika <Mounika.Kopparapu@amd.com>

Acked-by : Siva Addepalli<saddepal@xilinx.com>
Misra C violation rule 9.3:Arrays shall not be partially initialized.

Soln: Fixed by unintializing array which will be initialzed by function implicitly.

Signed-off-by: Leela Priyanka <LeelaPriyanka.Chinathota@amd.com>
Acked-by: Durga Challa <durga.challa@amd.com>
Remove extra token at end of #ifdef directive.

Signed-off-by: Harsha Harsha <harsha.harsha@amd.com>
Acked-by: Kalyani Akula <kalyani.akula@amd.com>
Currently HcleanDone value is not cleared during securelockdown which is why it is returning error.
so, clear the HcleanDone value during the secure lockdown and also skip plhouseclean.

Signed-off-by: Sandeep Reddy Ghanapuram <sandeep.reddy-ghanapuram@amd.com>
Signed-off-by: Sangshetty Patil <sangshetty.patil@amd.com>
Acked-by: Trung Tran <trung.tran@amd.com>
Update code to get 3 TTC instances for each TTC IP/node
in SDT flow.

Signed-off-by: Appana Durga Kedareswara rao <appana.durga.kedareswara.rao@amd.com>
Tested-by: M Lakshmaiah <lakshmaiah.m@amd.com>
Acked-by: Siva Durga Prasad Paladugu <siva.durga.prasad.paladugu@amd.com>
Addresing the following coverity errors whereever applicable for OpenAMP
APPs

DC.STRING_BUFFER
RESOURCE_LEAK
UNINIT

MISRA C-2012 Directive 4.4
MISRA C-2012 Directive 4.6
MISRA C-2012 Rule 10.3
MISRA C-2012 Rule 14.4
MISRA C-2012 Rule 17.12
MISRA C-2012 Rule 7.2
MISRA C-2012 Rule 8.4
MISRA C-2012 Rule 9.1

Signed-off-by: Rajiv Mohan <rajiv.mohan@amd.com>
Acked-by: Arun Kannan <arunbala@amd.com>
Add the generic compatible name for SDI Txss driver.

Signed-off-by: Katta Dhanunjanrao <katta.dhanunjanrao@amd.com>

Acked-for-series: Gaddipati, Naveen <naveen.gaddipati@amd.com>
Add the generic compatible name for SDI rxss

Signed-off-by: Katta Dhanunjanrao <katta.dhanunjanrao@amd.com>

Acked-for-series: Gaddipati, Naveen <naveen.gaddipati@amd.com>
Add the generic compatible name for SDI audio

Signed-off-by: Katta Dhanunjanrao <katta.dhanunjanrao@amd.com>

Acked-for-series: Gaddipati, Naveen <naveen.gaddipati@amd.com>
Add the compatible name for SDI tx core driver.

Signed-off-by: Katta Dhanunjanrao <katta.dhanunjanrao@amd.com>

Acked-for-series: Gaddipati, Naveen <naveen.gaddipati@amd.com>
Add the generic compatible name for the SDI rx core driver.

Signed-off-by: Katta Dhanunjanrao <katta.dhanunjanrao@amd.com>

Acked-for-series: Gaddipati, Naveen <naveen.gaddipati@amd.com>
The range of offchip revoke id is corrected to match with range of revocation eFuses.

Signed-off-by: VSSLakshmiPrasanna.Vutukuri <vsslakshmiprasanna.vutukuri@amd.com>
Acked-by: Kundanala, Praveen Teja <praveen.teja.kundanala@amd.com>
…ays be running out of processor instructions

Update the code to pick default timer in case of PSM microblaze
processor.

Signed-off-by: Appana Durga Kedareswara rao <appana.durga.kedareswara.rao@amd.com>
Acked-by: Siva Durga Prasad Paladugu <siva.durga.prasad.paladugu@amd.com>
…l handling for microblaze_interrupt_handler.c

When microblaze is compiled with flto need to compile
microblaze_interrupt_handler.c file without flto flags
otherwise microblaze vector table is getting corrupted,
this inlines with the xsct flow.

Signed-off-by: Appana Durga Kedareswara rao <appana.durga.kedareswara.rao@amd.com>

Acked-for-series: Siva Durga Prasad Paladugu <siva.durga.prasad.paladugu@amd.com>
…der while creating the archive

With the existing CMakeLists.txt in generated libxil.a drivers archive
objects are getting appended in reverse order.

The issue with the archives being appended in reverse order is likely due
to the way the list(APPEND ...) command works in CMake. When you append
items to a list within a loop, the items are added in the order they are
encountered. However, if the loop processes items in reverse order,
the final list will reflect that, Fix the archive objects getting
appended in reverse order issue by reversing the OBJS list.

Signed-off-by: Appana Durga Kedareswara rao <appana.durga.kedareswara.rao@amd.com>

Acked-for-series: Siva Durga Prasad Paladugu <siva.durga.prasad.paladugu@amd.com>
commit 7bd88c1("esw: set default compiler flags in the toolchain file
itself") moved the default compiler flags to toolchain file, we are
overriding these flags on special cases like a53 32-bit use FORCE
option while overriding otherwise prior flags are taking priority.

Signed-off-by: Appana Durga Kedareswara rao <appana.durga.kedareswara.rao@amd.com>

Acked-for-series: Siva Durga Prasad Paladugu <siva.durga.prasad.paladugu@amd.com>
…CFU clk freq

Fix 2 potential security issues related to the CFU clk frequency control.
1. When PLM reduces frequency, it should check if MSB is set; otherwise, the frequency remains the same.
   This is to prevent from overflowing.
2. When PLM sets the frequency register, it uses XSECURE_REDUNDANT_IMPL() for the double write.

Signed-off-by: jaychou <jay.chou@amd.com>
Acked-by: Jesus De Haro <jesus.de-haro@amd.com>
Remove folders deletion in xilloader, xilpdi, xilplmi, xilpm and
xilsecure tcl files

Signed-off-by: Kalyani Akula <kalyani.akula@xilinx.com>
Acked-by: Sreedhar Kundella <sreedhar.kundella@amd.com>
Add window program and update ECAM, base address.

Signed-off-by: Bhavana Jupalli <Bhavana.Jupalli@amd.com>
Acked-by: Thippeswamy Havalige <thippeswamy.havalige@amd.com>
…bytes read

Add support for non-blocking read, unaligned bytes read
and also correct spelling mistakes in comments.

Signed-off-by: Srikanth Boyapally <srikanth.boyapally@amd.com>

Acked-for-series: Srinivas Goud <srinivas.goud@amd.com>
Update example to support reading unaligned bytes.

Signed-off-by: Srikanth Boyapally <srikanth.boyapally@amd.com>

Acked-for-series: Srinivas Goud <srinivas.goud@amd.com>
Added doxygen groupings and fixed doxygen comments for all client and
common files in xilasu library.

Signed-off-by: Palakurthy Yogitha <palakurthy.yogitha@amd.com>

Acked-for-series: VNSL Durga Challa <vnsl.durga.challa@xilinx.com>
… AES

Added doxygen groupings and fixed doxygen warnings for ECC, RSA and AES
driver files and handlers.

Signed-off-by: Palakurthy Yogitha <palakurthy.yogitha@amd.com>

Acked-for-series: VNSL Durga Challa <vnsl.durga.challa@xilinx.com>
jbuddhab and others added 23 commits October 28, 2024 14:34
…PI events"

This reverts commit acde630.

With this commit observing RCU stalls and kernal panic during CPU
hot plug stress testing. Also observing issues in RPU suspend resume due
to wakeup interrupt is missed in PLM. So revert this commit as temporary
solution.

Signed-off-by: Jay Buddhabhatti <jay.buddhabhatti@amd.com>

Acked-for-series: Arun Balaji Kannan <arunbala@amd.com>
updated the condition to enhance the functionality to ensure the default
timer is used when ticktimer is set to None and modified xiltimer.cmake
to initialize tick_timer to "None" when there is no interval timer enabled.
this change prevents uninitialized variables and ensures that the logic
for setting XTIMER_NO_TICK_TIMER is correctly applied, facilitating
better handling of timer instances and updated library_utils.py to
enable the interval timer automatically for FreeRTOS, ensuring the
proper functionality.

Signed-off-by: M Lakshmaiah <lakshmaiah.m@amd.com>
Acked-by: Appana Durga Kedareswara rao <appana.durga.kedareswara.rao@amd.com>
…g PPDI

Fix optional data start address calculation by
considering SMAP_BUS_WIDTH_LENGTH during PPDI load

Signed-off-by: Praveen Teja Kundanala <praveen.teja.kundanala@amd.com>
Acked-by: Bharath Mulagondla <Bharath.mulagondla@amd.com>
Redundancy checks for dynamic reconfiguration is added as per security best practices

Signed-off-by: VSSLakshmiPrasanna.Vutukuri <vsslakshmiprasanna.vutukuri@amd.com>
Acked-by: Kundanala, Praveen Teja <praveen.teja.kundanala@amd.com>
END label in XSecure_AesDecryptUpdate is removed as it is not used
anywhere in the function

Signed-off-by: VSSLakshmiPrasanna.Vutukuri <vsslakshmiprasanna.vutukuri@amd.com>
Acked-by: Kundanala, Praveen Teja <praveen.teja.kundanala@amd.com>
Stack overflow protection has never been supported for FreeRTOS Microblaze port and
enabling it will unnecessarily result in other failures. Hence update portmacro.h
accordingly to not enable stack overflow protection for FreeRTOS MB port.

Signed-off-by: Siva Durga Prasad Paladugu <siva.durga.prasad.paladugu@amd.com>
Acked-by: Anirudha Sarangi <anirudha.sarangi@amd.com>
Remove the second xparameters.h file open call for the newly added
param.

Signed-off-by: Nandanikhil Gajulapally <nandanikhil.gajulapally@amd.com>
Acked-by: Harsha <harsha.harsha@xilinx.com>
During some segmented boot designs AIE is being put into reset during
XPm_InitFinalize because it is not being used until secondary PDI gets loaded
from Linux. As a temporary solution, add AIE device node to the exclude list so
that it is not released and not put into reset.

Signed-off-by: Nicole Baze <amanda.baze@amd.com>
Acked-by: Jay Buddhabhatti <jay.buddhabhatti@amd.com>
Current KeyholeXfr Optimization logic is not considering
the temporary buffer logic that's present to handle the
CDO commands broken near the chunk boundary. Fixed it
by correcting the condition used to get the next chunk
address.

Signed-off-by: Bharath Mulagondla <bharath.mulagondla@amd.com>
Acked-by: Mounika Akula <mounika.akula@amd.com>
For versel net, increase the bytebuffer size to 78K to accommodate large
size of configuration data (for error mgmt, subsystem definition etc).

Signed-off-by: Izhar Ameer Shaikh <izhar.ameer.shaikh@amd.com>
Acked-by: Buddhabhatti, Jay <jay.buddhabhatti@amd.com>
Acked-by: Jain, Kush <kush.jain@amd.com>
AIE2 is getting released during segmented boot flow. Add PMC request for AIE2
to keep it on even when it is not requested by a client.

Signed-off-by: Nicole Baze <amanda.baze@amd.com>
Acked-by: Jay Buddhabhatti <jay.buddhabhatti@amd.com>
Signed-off-by: Manikanta Sreeram <manikanta.sreeram@amd.com>
Updated changelog for 2024.2

Signed-off-by: Kopparapu,Mounika <Mounika.Kopparapu@amd.com>
The SPK ID used during boot shall be used during generation of
X.509 certificate during runtime. Hence, storing it in a static variable.

Signed-off-by: Harsha Harsha <harsha.harsha@amd.com>

Acked-for-series: Bharath Mulagondla <Bharath.mulagondla@amd.com>
In order to create Version sub field in the TCB Info extension of
X.509 certificate, user will add the version in the optional data
with data id ranging from 0x2000 to 0x200F.
This will be extracted and stored in DevAkData structure so that
it can be used to generate certificate.
This should also be retained during In Place PLM update.

Signed-off-by: Harsha Harsha <harsha.harsha@amd.com>

Acked-for-series: Bharath Mulagondla <Bharath.mulagondla@amd.com>
Added Version and svn sub-fields in the TCB Info extension of
DevIk CSR, DevIK and DevAk X.509 certificates.

Signed-off-by: Harsha Harsha <harsha.harsha@amd.com>

Acked-for-series: Bharath Mulagondla <Bharath.mulagondla@amd.com>
Updated changelog for 2024.2

Signed-off-by: Kalyani Akula <kalyani.akula@xilinx.com>

Acked-by : Siva Addepalli<saddepal@xilinx.com>
Signed-off-by: Bhawana Sahu <bhawana.sahu@amd.com>

Acked-by : Siva Addepalli<saddepal@xilinx.com>
Application is failing when HDCP2.2 only is enabled in both RX and TX.
Some functions are enabled without any HDCP Macros by default.
Now those are fixed.

Signed-off-by: Lakshmi Prasanna Eachuri <lakshmi.prasanna.eachuri@amd.com>
Doxygen warnings and code documentation fixes for SYSMONPSV driver.

Signed-off-by: Neelima Patel <Neelima.Patel@amd.com>
Acked-by: Erim, Salih <Salih.Erim@amd.com>
Siva Addepalli and others added 3 commits December 3, 2024 10:44
A lot of people are trying to send pull requests via github but this is not
the right channel to use. Linux project is doing review over emails that's
why use git@xilinx.com if you want to contribute changes to this
repository.

Signed-off-by: Siva Addepalli <sivaprasad.addepalli@xilinx.com>
…TC2/3 properly

When using the isolation-enabled design. BSP doesn't find either TTC2 or
TTC3 even if it's in the subsystem for the target processor.  The
problem is in `is_ttc_accessible_from_processor`: the argument passed to
`-filter` looks different from other places.

Signed-off-by: Kenta Sato <tosainu.maple@gmail.com>
@saddepal saddepal force-pushed the master branch 2 times, most recently from e929ef8 to 51d9eed Compare June 10, 2025 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.