From 7d8a73b750eff54991f8ef8974fff551d198d395 Mon Sep 17 00:00:00 2001 From: tsthght <781181214@qq.com> Date: Fri, 11 Oct 2019 15:49:15 +0800 Subject: [PATCH] expression: implement vectorized evaluation for 'builtinDurationAnyValueSig' (#12605) --- expression/builtin_miscellaneous_vec.go | 4 ++-- expression/builtin_miscellaneous_vec_test.go | 3 +++ 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/expression/builtin_miscellaneous_vec.go b/expression/builtin_miscellaneous_vec.go index 46eb27ab41780..4c80bfeabe0c3 100644 --- a/expression/builtin_miscellaneous_vec.go +++ b/expression/builtin_miscellaneous_vec.go @@ -161,11 +161,11 @@ func (b *builtinLockSig) vecEvalInt(input *chunk.Chunk, result *chunk.Column) er } func (b *builtinDurationAnyValueSig) vectorized() bool { - return false + return true } func (b *builtinDurationAnyValueSig) vecEvalDuration(input *chunk.Chunk, result *chunk.Column) error { - return errors.Errorf("not implemented") + return b.args[0].VecEvalDuration(b.ctx, input, result) } func (b *builtinIntAnyValueSig) vectorized() bool { diff --git a/expression/builtin_miscellaneous_vec_test.go b/expression/builtin_miscellaneous_vec_test.go index c45d0d3204ad1..717fc5b97b2e5 100644 --- a/expression/builtin_miscellaneous_vec_test.go +++ b/expression/builtin_miscellaneous_vec_test.go @@ -36,6 +36,9 @@ var vecBuiltinMiscellaneousCases = map[string][]vecExprBenchCase{ ast.IsIPv4: { {retEvalType: types.ETInt, childrenTypes: []types.EvalType{types.ETString}}, }, + ast.AnyValue: { + {retEvalType: types.ETDuration, childrenTypes: []types.EvalType{types.ETDuration}}, + }, ast.NameConst: { {retEvalType: types.ETDuration, childrenTypes: []types.EvalType{types.ETString, types.ETDuration}}, },