[lld-macho] Remove unneeded functions from BPSectionOrderer. NFC

Author: MaskRay

lld/MachO/BPSectionOrderer.cpp

@@ -26,8 +26,7 @@ DenseMap<const InputSection *, int> lld::macho::runBalancedPartitioning(
         auto *isec = subsec.isec;
         if (!isec || isec->data.empty() || !isec->data.data())
           continue;
-        sections.emplace_back(
-            std::make_unique<BPSectionMacho>(isec, sections.size()));
+        sections.emplace_back(std::make_unique<BPSectionMacho>(isec));
       }
     }
   }
@@ -38,11 +37,10 @@ DenseMap<const InputSection *, int> lld::macho::runBalancedPartitioning(
 
   DenseMap<const InputSection *, int> result;
   for (const auto &[sec, priority] : reorderedSections) {
-    if (auto *machoSection = dyn_cast<BPSectionMacho>(sec)) {
-      result.try_emplace(
-          static_cast<const InputSection *>(machoSection->getSection()),
-          priority);
-    }
+    result.try_emplace(
+        static_cast<const InputSection *>(
+            static_cast<const BPSectionMacho *>(sec)->getSection()),
+        priority);
   }
   return result;
 }

lld/MachO/BPSectionOrderer.h

@@ -57,18 +57,14 @@ class BPSymbolMacho : public BPSymbol {
 
 class BPSectionMacho : public BPSectionBase {
   const InputSection *isec;
-  uint64_t sectionIdx;
 
 public:
-  explicit BPSectionMacho(const InputSection *sec, uint64_t sectionIdx)
-      : isec(sec), sectionIdx(sectionIdx) {}
+  explicit BPSectionMacho(const InputSection *sec) : isec(sec) {}
 
   const void *getSection() const override { return isec; }
 
   uint64_t getSize() const override { return isec->getSize(); }
 
-  uint64_t getSectionIdx() const { return sectionIdx; }
-
   bool isCodeSection() const override { return macho::isCodeSection(isec); }
 
   SmallVector<std::unique_ptr<BPSymbol>> getSymbols() const override {
@@ -118,8 +114,6 @@ class BPSectionMacho : public BPSectionBase {
     hashes.erase(std::unique(hashes.begin(), hashes.end()), hashes.end());
   }
 
-  static bool classof(const BPSectionBase *s) { return true; }
-
 private:
   static uint64_t
   getRelocHash(const Reloc &reloc,