2261 Add basic authentication support to Solr health check #2263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dotnet-policy-service agree company="NEOGOV" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds basic authentication support to the Solr health check.
Which issue(s) this PR fixes:
Most enterprise environments configure Solr to use SSL and some sort of authentication. This PR adds basic authentication support to the Solr health check.
Please reference the issue this PR will close: #[issue number]
#2261
Special notes for your reviewer:
Some of the existing Solr unit tests required a higher timeout from the default of 1 second in order to succeed. However I did not commit those temporary changes since it's likely it's my local testing environment. Also the new unit test I wrote requires Solr to be configured to use basic authentication.
Does this PR introduce a user-facing change?:
No. All changes are opt-in/optional.
Please make sure you've completed the relevant tasks for this PR, out of the following list: